From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>
Subject: [Qemu-devel] [PATCH v2 8/8] dump-query: make the percentage accurate.
Date: Fri, 27 Nov 2015 10:48:17 +0800 [thread overview]
Message-ID: <1448592497-2462-9-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1448592497-2462-1-git-send-email-peterx@redhat.com>
By calculating the total_size and written_size of memory, we could
get relatively accurate percentage of finished dump.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
dump.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index 65bd5fb..0fcad28 100644
--- a/dump.c
+++ b/dump.c
@@ -1643,8 +1643,9 @@ static const char *const dump_result_table[] = {
* resources using qapi_free_DumpStatus(). */
DumpStatus *dump_status_query(void)
{
+ DumpState *state = NULL;
DumpStatus *status = g_malloc0(sizeof(*status));
- int percentage = 50;
+ float percentage = 0;
char buf[64] = {0};
GlobalDumpState *global = dump_state_get_global();
@@ -1653,7 +1654,9 @@ DumpStatus *dump_status_query(void)
/* TBD: get correct percentage */
status->status = g_strdup(dump_result_table[global->gds_result]);
if (global->gds_result == DUMP_RES_IN_PROGRESS) {
- snprintf(buf, sizeof(buf) - 1, "%d%%", percentage);
+ state = global->gds_cur;
+ percentage = 100.0 * state->written_size / state->total_size;
+ snprintf(buf, sizeof(buf) - 1, "%.2f%%", percentage);
status->percentage = g_strdup(buf);
} else {
status->percentage = g_strdup("N/A");
--
2.4.3
next prev parent reply other threads:[~2015-11-27 2:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 2:48 [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}() Peter Xu
2015-11-27 4:28 ` Fam Zheng
2015-11-27 6:51 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces Peter Xu
2015-11-27 4:31 ` Fam Zheng
2015-11-27 6:05 ` Peter Xu
2015-11-30 18:21 ` Eric Blake
2015-12-01 1:28 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support Peter Xu
2015-11-27 5:14 ` Fam Zheng
2015-11-27 5:20 ` Fam Zheng
2015-11-27 6:27 ` Peter Xu
2015-11-27 10:14 ` Paolo Bonzini
2015-11-27 11:03 ` Peter Xu
2015-11-28 5:51 ` Peter Xu
2015-11-30 1:48 ` Fam Zheng
2015-11-27 10:31 ` Paolo Bonzini
2015-11-27 11:26 ` Peter Xu
2015-11-27 11:52 ` Paolo Bonzini
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED Peter Xu
2015-11-27 5:19 ` Fam Zheng
2015-11-27 6:43 ` Peter Xu
2015-11-27 10:15 ` Paolo Bonzini
2015-11-27 11:29 ` Peter Xu
2015-11-30 18:18 ` Eric Blake
2015-12-01 1:52 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status Peter Xu
2015-11-27 5:25 ` Fam Zheng
2015-11-27 7:03 ` Peter Xu
2015-11-27 10:17 ` Paolo Bonzini
2015-11-27 11:33 ` Peter Xu
2015-11-30 18:27 ` Eric Blake
2015-12-01 2:03 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command Peter Xu
2015-11-27 10:22 ` Paolo Bonzini
2015-11-27 11:42 ` Peter Xu
2015-11-27 11:53 ` Paolo Bonzini
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 7/8] DumpState: adding total_size and written_size fields Peter Xu
2015-11-27 2:48 ` Peter Xu [this message]
2015-11-27 2:59 ` [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory Peter Xu
2015-11-27 5:28 ` Fam Zheng
2015-11-27 6:53 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448592497-2462-9-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).