* [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest
@ 2015-11-30 11:19 Michael S. Tsirkin
2015-11-30 11:22 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-11-30 11:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Dmitry Fleytman, Jason Wang
This is not a user error, don't warn.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/vmxnet3.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 5e3a233..0e9e6d9 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -25,6 +25,7 @@
#include "qemu/bswap.h"
#include "hw/pci/msix.h"
#include "hw/pci/msi.h"
+#include "sysemu/qtest.h"
#include "vmxnet3.h"
#include "vmxnet_debug.h"
@@ -2015,7 +2016,9 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
return true;
}
- VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
+ if (!qtest_enabled()) {
+ VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
+ }
return false;
}
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest
2015-11-30 11:19 [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest Michael S. Tsirkin
@ 2015-11-30 11:22 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-11-30 11:22 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Dmitry Fleytman, Jason Wang
On 30/11/2015 12:19, Michael S. Tsirkin wrote:
> This is not a user error, don't warn.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/net/vmxnet3.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5e3a233..0e9e6d9 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -25,6 +25,7 @@
> #include "qemu/bswap.h"
> #include "hw/pci/msix.h"
> #include "hw/pci/msi.h"
> +#include "sysemu/qtest.h"
>
> #include "vmxnet3.h"
> #include "vmxnet_debug.h"
> @@ -2015,7 +2016,9 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
> return true;
> }
>
> - VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> + if (!qtest_enabled()) {
> + VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> + }
> return false;
> }
Let's just delete it, there's no similar warning for virtio.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-30 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 11:19 [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest Michael S. Tsirkin
2015-11-30 11:22 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).