From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Meq-0006DR-Ht for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:30:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Mel-0003Yz-Oq for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:30:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Mel-0003YZ-KI for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:30:07 -0500 Date: Mon, 30 Nov 2015 13:30:04 +0200 From: "Michael S. Tsirkin" Message-ID: <1448882964-22433-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH for-2.5] main-loop: suppress warnings under qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini commit 01c22f2cdd4fcf02276ea10f48253850a5fd7259 ("main-loop: Suppress "I/O thread spun" warnings for qtest") doesn't actually disable the warning for everyone since some tests don't run under the qtest accelerator. Check qtest_driver instead. Cc: Peter Maydell Signed-off-by: Michael S. Tsirkin --- main-loop.c | 2 +- stubs/qtest.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/main-loop.c b/main-loop.c index df28670..5877615 100644 --- a/main-loop.c +++ b/main-loop.c @@ -230,7 +230,7 @@ static int os_host_main_loop_wait(int64_t timeout) if (!timeout && (spin_counter > MAX_MAIN_LOOP_SPIN)) { static bool notified; - if (!notified && !qtest_enabled()) { + if (!notified && !qtest_driver()) { fprintf(stderr, "main-loop: WARNING: I/O thread spun for %d iterations\n", MAX_MAIN_LOOP_SPIN); diff --git a/stubs/qtest.c b/stubs/qtest.c index dc17594..4dfde61 100644 --- a/stubs/qtest.c +++ b/stubs/qtest.c @@ -12,3 +12,8 @@ /* Needed for qtest_allowed() */ bool qtest_allowed; + +bool qtest_driver(void) +{ + return false; +} -- MST