From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3RNX-0004NV-Lq for qemu-devel@nongnu.org; Mon, 30 Nov 2015 11:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3RNS-0003UF-V7 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 11:32:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3RNS-0003Tz-Oy for qemu-devel@nongnu.org; Mon, 30 Nov 2015 11:32:34 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 7A3E968E23 for ; Mon, 30 Nov 2015 16:32:34 +0000 (UTC) From: Markus Armbruster Date: Mon, 30 Nov 2015 17:32:32 +0100 Message-Id: <1448901152-11716-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] coverity: Model g_memdup() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com We model all the non-deprecated memory allocation functions from https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html except for g_memdup(), g_clear_pointer(), g_steal_pointer(). We don't use the latter two. Model the former. Coverity now reports an OVERRUN vl.c:2317: alloc_strlen: Allocating insufficient memory for the terminating null of the string. Correct, but we omit the terminating null intentionally there. Signed-off-by: Markus Armbruster --- scripts/coverity-model.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c index 617f67d..e1d5f45 100644 --- a/scripts/coverity-model.c +++ b/scripts/coverity-model.c @@ -236,6 +236,23 @@ void *g_try_realloc(void *ptr, size_t size) return g_try_realloc_n(ptr, 1, size); } +/* Other memory allocation functions */ + +void *g_memdup(const void *ptr, unsigned size) +{ + unsigned char *dup; + unsigned i; + + if (!ptr) { + return NULL; + } + + dup = g_malloc(size); + for (i = 0; i < size; i++) + dup[i] = ((unsigned char *)ptr)[i]; + return dup; +} + /* * GLib string allocation functions */ -- 2.4.3