qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
	qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before write notifier again
Date: Tue,  1 Dec 2015 17:36:27 +0800	[thread overview]
Message-ID: <1448962590-2842-1-git-send-email-famz@redhat.com> (raw)

This is basically a supplementary fix of 06c3916b.

On 512 disks, the crash only happens when copy-on-read is enabled, which is
covered by the previou fix.  But on 4k disks the write request that triggers
the notifier itself may be serialised, in which case the read req from
backup_do_cow will still be serialised in bdrv_aligned_preadv, resulting in the
same assertion failure.

Fam Zheng (3):
  block: Don't wait serialising for non-COR read requests
  iotests: Add "add_drive_raw" method
  iotests: Add regresion test case for write notifier assertion failure

 block/backup.c                |  2 +-
 block/io.c                    | 12 +++++++-----
 include/block/block.h         |  4 ++--
 tests/qemu-iotests/056        | 25 +++++++++++++++++++++++++
 tests/qemu-iotests/056.out    |  4 ++--
 tests/qemu-iotests/iotests.py |  5 +++++
 trace-events                  |  2 +-
 7 files changed, 43 insertions(+), 11 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-12-01  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01  9:36 Fam Zheng [this message]
2015-12-01  9:36 ` [Qemu-devel] [PATCH 1/3] block: Don't wait serialising for non-COR read requests Fam Zheng
2015-12-01  9:54   ` Kevin Wolf
2015-12-01 10:26     ` Fam Zheng
2015-12-01 11:00       ` Kevin Wolf
2015-12-01  9:36 ` [Qemu-devel] [PATCH 2/3] iotests: Add "add_drive_raw" method Fam Zheng
2015-12-01  9:36 ` [Qemu-devel] [PATCH 3/3] iotests: Add regresion test case for write notifier assertion failure Fam Zheng
2015-12-03  6:50 ` [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before write notifier again Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448962590-2842-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).