From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.a@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 12/16] pc: Remove PcGuestInfo.isapc_ram_fw field
Date: Tue, 1 Dec 2015 23:47:07 -0200 [thread overview]
Message-ID: <1449020831-8414-13-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1449020831-8414-1-git-send-email-ehabkost@redhat.com>
The code can use the PCMachineClass.pci_enabled field directly.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/pc.c | 2 +-
hw/i386/pc_piix.c | 1 -
hw/i386/pc_q35.c | 1 -
include/hw/i386/pc.h | 1 -
4 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a9ec402..82025e2 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1364,7 +1364,7 @@ FWCfgState *pc_memory_init(PCMachineState *pcms,
}
/* Initialize PC system firmware */
- pc_system_firmware_init(rom_memory, guest_info->isapc_ram_fw);
+ pc_system_firmware_init(rom_memory, !pcmc->pci_enabled);
option_rom_mr = g_malloc(sizeof(*option_rom_mr));
memory_region_init_ram(option_rom_mr, NULL, "pc.rom", PC_ROM_SIZE,
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index f39c086..1828cf8 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -145,7 +145,6 @@ static void pc_init1(MachineState *machine,
guest_info->has_acpi_build = pcmc->has_acpi_build;
guest_info->legacy_acpi_table_size = pcmc->legacy_acpi_table_size;
- guest_info->isapc_ram_fw = !pcmc->pci_enabled;
guest_info->has_reserved_memory = pcmc->has_reserved_memory;
guest_info->rsdp_in_ram = pcmc->rsdp_in_ram;
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 7563bca..f124e59 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -132,7 +132,6 @@ static void pc_q35_init(MachineState *machine)
}
guest_info = pc_guest_info_init(pcms);
- guest_info->isapc_ram_fw = false;
guest_info->has_acpi_build = pcmc->has_acpi_build;
guest_info->has_reserved_memory = pcmc->has_reserved_memory;
guest_info->rsdp_in_ram = pcmc->rsdp_in_ram;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 2732a72..64f2b4b 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -22,7 +22,6 @@
/* Machine info for ACPI build: */
struct PcGuestInfo {
- bool isapc_ram_fw;
unsigned apic_id_limit;
bool apic_xrupt_override;
uint64_t numa_nodes;
--
2.1.0
next prev parent reply other threads:[~2015-12-02 1:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 1:46 [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo Eduardo Habkost
2015-12-02 1:46 ` [Qemu-devel] [PATCH 01/16] pc: Move PcGuestInfo declaration to top of file Eduardo Habkost
2015-12-02 1:46 ` [Qemu-devel] [PATCH 02/16] pc: Eliminate struct PcGuestInfoState Eduardo Habkost
2015-12-07 15:19 ` Marcel Apfelbaum
2015-12-02 1:46 ` [Qemu-devel] [PATCH 03/16] pc: Remove guest_info parameter from pc_memory_init() Eduardo Habkost
2015-12-02 1:46 ` [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument Eduardo Habkost
2015-12-07 15:24 ` Marcel Apfelbaum
2015-12-08 17:40 ` Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 05/16] acpi: Remove unused build_facs() PcGuestInfo paramter Eduardo Habkost
2015-12-07 15:25 ` Marcel Apfelbaum
2015-12-02 1:47 ` [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState Eduardo Habkost
2015-12-07 15:39 ` Marcel Apfelbaum
2015-12-08 17:59 ` Eduardo Habkost
2015-12-08 18:44 ` Marcel Apfelbaum
2015-12-09 19:37 ` Igor Mammedov
2015-12-11 14:12 ` Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 07/16] acpi: Make acpi_build() get PCMachineState as argument Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 08/16] acpi: Make build_srat() " Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 09/16] acpi: Remove ram size fields fron PcGuestInfo Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 10/16] pc: Move PcGuestInfo.fw_cfg field to PCMachineState Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 11/16] pc: Simplify signature of xen_load_linux() Eduardo Habkost
2015-12-11 11:40 ` Stefano Stabellini
2015-12-02 1:47 ` Eduardo Habkost [this message]
2015-12-02 1:47 ` [Qemu-devel] [PATCH 13/16] q35: Remove MCHPCIState.guest_info field Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 14/16] acpi: Use PCMachineClass fields directly Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 15/16] pc: Move PcGuestInfo.apic_xrupt_override field to PCMachineState Eduardo Habkost
2015-12-02 1:47 ` [Qemu-devel] [PATCH 16/16] pc: Move APIC and NUMA data from PcGuestInfo " Eduardo Habkost
2015-12-07 18:57 ` [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo Marcel Apfelbaum
2015-12-08 17:53 ` Eduardo Habkost
2015-12-10 11:27 ` Marcel Apfelbaum
2015-12-10 17:45 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449020831-8414-13-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).