From: Yang Wei <w90p710@gmail.com>
To: blauwirbel@gmail.com, stefanha@redhat.com, avi@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] scripts/gdb: Fix a python exception in mtree.py
Date: Wed, 2 Dec 2015 15:56:24 +0800 [thread overview]
Message-ID: <1449042984-10609-1-git-send-email-w90p710@gmail.com> (raw)
The following exception is threw:
Python Exception <class 'NameError'> name 'long' is not defined:
Error occurred in Python command: name 'long' is not defined
In python3, long is rename to int
Signed-off-by: Yang Wei <w90p710@gmail.com>
---
scripts/qemugdb/mtree.py | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py
index 06011c3..460d4b6 100644
--- a/scripts/qemugdb/mtree.py
+++ b/scripts/qemugdb/mtree.py
@@ -16,12 +16,19 @@
# 'qemu mtree' -- display the memory hierarchy
import gdb
+import sys
def isnull(ptr):
return ptr == gdb.Value(0).cast(ptr.type)
+# PEP 0237: long renamed to int. That is, there is only one built-integral
+# integral type, named int; but it behaves mostly like the old long type.
+# https://docs.python.org/3.3/whatsnew/3.0.html#integers
+def intptr(p):
+ return long(p) if sys.version_info.major == 2 else int(p)
+
def int128(p):
- return long(p['lo']) + (long(p['hi']) << 64)
+ return intptr(p['lo']) + (intptr(p['hi']) << 64)
class MtreeCommand(gdb.Command):
'''Display the memory tree hierarchy'''
@@ -40,11 +47,11 @@ class MtreeCommand(gdb.Command):
def process_queue(self):
while self.queue:
ptr = self.queue.pop(0)
- if long(ptr) in self.seen:
+ if intptr(ptr) in self.seen:
continue
self.print_item(ptr)
def print_item(self, ptr, offset = gdb.Value(0), level = 0):
- self.seen.add(long(ptr))
+ self.seen.add(intptr(ptr))
addr = ptr['addr']
addr += offset
size = int128(ptr['size'])
@@ -58,8 +65,8 @@ class MtreeCommand(gdb.Command):
klass = ' (RAM)'
gdb.write('%s%016x-%016x %s%s (@ %s)\n'
% (' ' * level,
- long(addr),
- long(addr + (size - 1)),
+ intptr(addr),
+ intptr(addr + (size - 1)),
ptr['name'].string(),
klass,
ptr,
--
1.9.1
next reply other threads:[~2015-12-02 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 7:56 Yang Wei [this message]
2015-12-04 1:43 ` [Qemu-devel] Fwd: scripts/gdb: Fix a python exception in mtree.py Zhang Yang
2015-12-04 6:22 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449042984-10609-1-git-send-email-w90p710@gmail.com \
--to=w90p710@gmail.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).