From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4E7k-0002Xb-6N for qemu-devel@nongnu.org; Wed, 02 Dec 2015 15:35:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4E7j-0002XN-CT for qemu-devel@nongnu.org; Wed, 02 Dec 2015 15:35:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4E7j-0002XG-7W for qemu-devel@nongnu.org; Wed, 02 Dec 2015 15:35:35 -0500 Date: Wed, 2 Dec 2015 22:35:32 +0200 From: "Michael S. Tsirkin" Message-ID: <1449088478-21099-5-git-send-email-mst@redhat.com> References: <1449088478-21099-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449088478-21099-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PULL 4/9] vhost-user: verify that number of queues is non-zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Jason Wang , Victor Kaplansky From: Victor Kaplansky Fix QEMU crash when -netdev type=vhost-user,queues=n is passed with zero number of queues. Signed-off-by: Victor Kaplansky Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang --- net/vhost-user.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 5071602..b368a90 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -316,6 +316,11 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name, } queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1; + if (queues < 1) { + error_setg(errp, + "vhost-user number of queues must be bigger than zero"); + return -1; + } return net_vhost_user_init(peer, "vhost_user", name, chr, queues); } -- MST