From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Uca-0004X5-Qn for qemu-devel@nongnu.org; Thu, 03 Dec 2015 09:12:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4Uca-0007JF-1I for qemu-devel@nongnu.org; Thu, 03 Dec 2015 09:12:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4UcZ-0007J2-Sr for qemu-devel@nongnu.org; Thu, 03 Dec 2015 09:12:31 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 763578F275 for ; Thu, 3 Dec 2015 14:12:31 +0000 (UTC) From: Eduardo Habkost Date: Wed, 2 Dec 2015 20:22:51 -0200 Message-Id: <1449094978-22986-7-git-send-email-ehabkost@redhat.com> In-Reply-To: <1449094978-22986-1-git-send-email-ehabkost@redhat.com> References: <1449094978-22986-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 06/13] acpi: Use &error_abort when getting PCI hotplug properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , Marcel Apfelbaum , "Michael S. Tsirkin" The properties must be present, so use &error_abort to ensure we don't ignore errors. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9a45a59..4f42e28 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -154,9 +154,11 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) obj = piix; pm->cpu_hp_io_base = PIIX4_CPU_HOTPLUG_IO_BASE; pm->pcihp_io_base = - object_property_get_int(obj, ACPI_PCIHP_IO_BASE_PROP, NULL); + object_property_get_int(obj, ACPI_PCIHP_IO_BASE_PROP, + &error_abort); pm->pcihp_io_len = - object_property_get_int(obj, ACPI_PCIHP_IO_LEN_PROP, NULL); + object_property_get_int(obj, ACPI_PCIHP_IO_LEN_PROP, + &error_abort); } if (lpc) { obj = lpc; -- 2.1.0