From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Gjs-0001d9-JR for qemu-devel@nongnu.org; Wed, 02 Dec 2015 18:23:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4Gjr-0002Gt-TW for qemu-devel@nongnu.org; Wed, 02 Dec 2015 18:23:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Gjr-0002Gh-Np for qemu-devel@nongnu.org; Wed, 02 Dec 2015 18:23:07 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 60EB18C1B2 for ; Wed, 2 Dec 2015 23:23:07 +0000 (UTC) From: Juan Quintela Date: Thu, 3 Dec 2015 00:23:01 +0100 Message-Id: <1449098581-6628-3-git-send-email-quintela@redhat.com> In-Reply-To: <1449098581-6628-1-git-send-email-quintela@redhat.com> References: <1449098581-6628-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PULL 2/2] migration: do floating-point division List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, Paolo Bonzini , dgilbert@redhat.com From: Paolo Bonzini Dividing integer expressions transferred_bytes and time_spent, and then converting the integer quotient to type double. Any remainder, or fractional part of the quotient, is ignored. Fix this. Signed-off-by: Paolo Bonzini Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 1a42aee..adc6b6f 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1674,7 +1674,7 @@ static void *migration_thread(void *opaque) if (current_time >= initial_time + BUFFER_DELAY) { uint64_t transferred_bytes = qemu_ftell(s->file) - initial_bytes; uint64_t time_spent = current_time - initial_time; - double bandwidth = transferred_bytes / time_spent; + double bandwidth = (double)transferred_bytes / time_spent; max_size = bandwidth * migrate_max_downtime() / 1000000; s->mbps = time_spent ? (((double) transferred_bytes * 8.0) / -- 2.5.0