From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Sjn-0003XO-AC for qemu-devel@nongnu.org; Thu, 03 Dec 2015 07:11:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4Sjj-0000yV-7R for qemu-devel@nongnu.org; Thu, 03 Dec 2015 07:11:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Sjj-0000xS-24 for qemu-devel@nongnu.org; Thu, 03 Dec 2015 07:11:47 -0500 Message-ID: <1449144702.3719.79.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 03 Dec 2015 13:11:42 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P , Peter Maydell Cc: qemu-devel@nongnu.org, Lian Yihan On Do, 2015-12-03 at 17:07 +0530, P J P wrote: > Hello Gerd, >=20 > A floating point exception issue in the VNC server PNG compression suppor= t was=20 > reported by Mr Lian Yihan, CC'd here. Given below is a proposed (tested)p= atch=20 > to fix this issue. > - vs->client_pf.rmax =3D red_max; > + vs->client_pf.rmax =3D red_max ? red_max : 0xFF; Looks good. Reviewed-by: Gerd Hoffmann Peter, can you pick this up directly for 2.5-rc3? thanks, Gerd