qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Liang Li <liang.z.li@intel.com>
To: qemu-devel@nongnu.org
Cc: Liang Li <liang.z.li@intel.com>,
	mit.shah@redhat.com, dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data
Date: Fri,  4 Dec 2015 11:52:07 +0800	[thread overview]
Message-ID: <1449201128-22779-2-git-send-email-liang.z.li@intel.com> (raw)
In-Reply-To: <1449201128-22779-1-git-send-email-liang.z.li@intel.com>

There are some flaws in qemu_put_compression_data, this patch tries
to fix it. Now it can be used by other code.

Signed-off-by: Liang Li <liang.z.li@intel.com>
---
 migration/qemu-file.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 0bbd257..ef9cd4a 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -616,7 +616,9 @@ ssize_t qemu_put_compression_data(QEMUFile *f, const uint8_t *p, size_t size,
     ssize_t blen = IO_BUF_SIZE - f->buf_index - sizeof(int32_t);
 
     if (blen < compressBound(size)) {
-        return 0;
+        if (f->ops->writev_buffer || f->ops->put_buffer) {
+            qemu_fflush(f);
+        }
     }
     if (compress2(f->buf + f->buf_index + sizeof(int32_t), (uLongf *)&blen,
                   (Bytef *)p, size, level) != Z_OK) {
@@ -624,7 +626,13 @@ ssize_t qemu_put_compression_data(QEMUFile *f, const uint8_t *p, size_t size,
         return 0;
     }
     qemu_put_be32(f, blen);
+    if (f->ops->writev_buffer) {
+        add_to_iovec(f, f->buf + f->buf_index, blen);
+    }
     f->buf_index += blen;
+    if (f->buf_index == IO_BUF_SIZE) {
+        qemu_fflush(f);
+    }
     return blen + sizeof(int32_t);
 }
 
-- 
1.9.1

  reply	other threads:[~2015-12-04  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  3:52 [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Liang Li
2015-12-04  3:52 ` Liang Li [this message]
2015-12-04 11:07   ` [Qemu-devel] [PATCH 1/2] qemu-file: fix " Juan Quintela
2015-12-04 14:25     ` Li, Liang Z
2015-12-04 19:44       ` Juan Quintela
2015-12-06 14:29         ` Li, Liang Z
2015-12-07  7:09   ` Stefan Hajnoczi
2015-12-07  7:09   ` Stefan Hajnoczi
2015-12-07  7:12     ` Li, Liang Z
2015-12-04  3:52 ` [Qemu-devel] [PATCH 2/2] migration: code clean up Liang Li
2015-12-04 11:02 ` [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Juan Quintela
2015-12-04 13:36   ` Li, Liang Z
  -- strict thread matches above, loose matches on Subject: below --
2015-12-04  3:53 Liang Li
2015-12-04  3:53 ` [Qemu-devel] [PATCH 1/2] qemu-file: fix " Liang Li
2015-12-04 12:48   ` Amit Shah
2015-12-04 14:29     ` Li, Liang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449201128-22779-2-git-send-email-liang.z.li@intel.com \
    --to=liang.z.li@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=mit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).