From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org, armbru@redhat.com
Cc: thuth@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 2/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device
Date: Fri, 4 Dec 2015 17:46:31 +1100 [thread overview]
Message-ID: <1449211592-18783-3-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1449211592-18783-1-git-send-email-david@gibson.dropbear.id.au>
From: Markus Armbruster <armbru@redhat.com>
It should only be created via spapr_dr_connector_new(). Attempting to
create it with -device crashes.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr_drc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 4e7a1d3..404fb3c 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -594,6 +594,10 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
drck->attach = attach;
drck->detach = detach;
drck->release_pending = release_pending;
+ /*
+ * Reason: it crashes FIXME find and document the real reason
+ */
+ dk->cannot_instantiate_with_device_add_yet = true;
}
static const TypeInfo spapr_dr_connector_info = {
--
2.5.0
next prev parent reply other threads:[~2015-12-04 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 6:46 [Qemu-devel] [PULL 0/3] ppc-for-2.5 queue 20151204 David Gibson
2015-12-04 6:46 ` [Qemu-devel] [PULL 1/3] spapr_drc: Handle visitor errors properly David Gibson
2015-12-04 6:46 ` David Gibson [this message]
2015-12-04 6:46 ` [Qemu-devel] [PULL 3/3] spapr_drc: Change value of property "fdt" from null back to {} David Gibson
2015-12-04 10:54 ` [Qemu-devel] [PULL 0/3] ppc-for-2.5 queue 20151204 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449211592-18783-3-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).