From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4k80-0006DX-7W for qemu-devel@nongnu.org; Fri, 04 Dec 2015 01:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4k7x-00059b-0K for qemu-devel@nongnu.org; Fri, 04 Dec 2015 01:46:00 -0500 From: David Gibson Date: Fri, 4 Dec 2015 17:46:31 +1100 Message-Id: <1449211592-18783-3-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1449211592-18783-1-git-send-email-david@gibson.dropbear.id.au> References: <1449211592-18783-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PULL 2/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org, armbru@redhat.com Cc: thuth@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, David Gibson From: Markus Armbruster It should only be created via spapr_dr_connector_new(). Attempting to create it with -device crashes. Signed-off-by: Markus Armbruster Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 4e7a1d3..404fb3c 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -594,6 +594,10 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) drck->attach = attach; drck->detach = detach; drck->release_pending = release_pending; + /* + * Reason: it crashes FIXME find and document the real reason + */ + dk->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo spapr_dr_connector_info = { -- 2.5.0