From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, afaerber@suse.de, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH] fixup! tests: Use proper functions types instead of void (*fn)
Date: Fri, 4 Dec 2015 08:59:59 +0100 [thread overview]
Message-ID: <1449215999-26220-1-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1449087634-30846-2-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/libqtest.c | 5 +++--
tests/libqtest.h | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index c52ceb2..fa314e1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -760,14 +760,15 @@ void qtest_memread(QTestState *s, uint64_t addr, void *data, size_t size)
g_strfreev(args);
}
-void qtest_add_func(const char *str, GTestFunc fn)
+void qtest_add_func(const char *str, void (*fn)(void))
{
gchar *path = g_strdup_printf("/%s/%s", qtest_get_arch(), str);
g_test_add_func(path, fn);
g_free(path);
}
-void qtest_add_data_func(const char *str, const void *data, GTestDataFunc fn)
+void qtest_add_data_func(const char *str, const void *data,
+ void (*fn)(const void *))
{
gchar *path = g_strdup_printf("/%s/%s", qtest_get_arch(), str);
g_test_add_data_func(path, data, fn);
diff --git a/tests/libqtest.h b/tests/libqtest.h
index d11b5a4..ebdd5bb 100644
--- a/tests/libqtest.h
+++ b/tests/libqtest.h
@@ -416,7 +416,7 @@ const char *qtest_get_arch(void);
* The path is prefixed with the architecture under test, as
* returned by qtest_get_arch().
*/
-void qtest_add_func(const char *str, GTestFunc fn);
+void qtest_add_func(const char *str, void (*fn)(void));
/**
* qtest_add_data_func:
@@ -428,7 +428,8 @@ void qtest_add_func(const char *str, GTestFunc fn);
* The path is prefixed with the architecture under test, as
* returned by qtest_get_arch().
*/
-void qtest_add_data_func(const char *str, const void *data, GTestDataFunc fn);
+void qtest_add_data_func(const char *str, const void *data,
+ void (*fn)(const void *));
/**
* qtest_add:
--
2.4.3
next prev parent reply other threads:[~2015-12-04 8:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 20:20 [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix Markus Armbruster
2015-12-02 20:20 ` [Qemu-devel] [PATCH for-2.5 1/2] tests: Use proper functions types instead of void (*fn) Markus Armbruster
2015-12-02 20:42 ` Eric Blake
2015-12-03 8:22 ` Markus Armbruster
2015-12-04 7:59 ` Markus Armbruster [this message]
2015-12-02 20:20 ` [Qemu-devel] [PATCH for-2.5 2/2] qom-test: fix qmp() leaks Markus Armbruster
2015-12-02 20:44 ` Eric Blake
2015-12-03 19:29 ` Andreas Färber
2015-12-03 10:54 ` [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix Peter Maydell
2015-12-03 12:06 ` Markus Armbruster
2015-12-03 12:57 ` Andreas Färber
2015-12-03 13:06 ` Peter Maydell
2015-12-03 16:13 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449215999-26220-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).