From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4q4h-0005UQ-Ls for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:07:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4q4d-0008H6-Hx for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:06:59 -0500 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:35529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4q4d-0008Gn-C8 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:06:55 -0500 Received: by pfu207 with SMTP id 207so26214691pfu.2 for ; Fri, 04 Dec 2015 05:06:54 -0800 (PST) From: Yang Wei Date: Fri, 4 Dec 2015 21:06:45 +0800 Message-Id: <1449234405-28345-1-git-send-email-w90p710@gmail.com> Subject: [Qemu-devel] [PATCH v2] scripts/gdb: Fix a python exception in mtree.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: blauwirbel@gmail.com, stefanha@redhat.com, peter.maydell@linaro.org Cc: qemu-devel@nongnu.org The following exception is threw: Python Exception name 'long' is not defined: Error occurred in Python command: name 'long' is not defined Python 2.4+, int()/long() have been unified, so replace long with int. Signed-off-by: Yang Wei --- scripts/qemugdb/mtree.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py index 06011c3..cc8131c 100644 --- a/scripts/qemugdb/mtree.py +++ b/scripts/qemugdb/mtree.py @@ -21,7 +21,7 @@ def isnull(ptr): return ptr == gdb.Value(0).cast(ptr.type) def int128(p): - return long(p['lo']) + (long(p['hi']) << 64) + return int(p['lo']) + (int(p['hi']) << 64) class MtreeCommand(gdb.Command): '''Display the memory tree hierarchy''' @@ -40,11 +40,11 @@ class MtreeCommand(gdb.Command): def process_queue(self): while self.queue: ptr = self.queue.pop(0) - if long(ptr) in self.seen: + if int(ptr) in self.seen: continue self.print_item(ptr) def print_item(self, ptr, offset = gdb.Value(0), level = 0): - self.seen.add(long(ptr)) + self.seen.add(int(ptr)) addr = ptr['addr'] addr += offset size = int128(ptr['size']) @@ -58,8 +58,8 @@ class MtreeCommand(gdb.Command): klass = ' (RAM)' gdb.write('%s%016x-%016x %s%s (@ %s)\n' % (' ' * level, - long(addr), - long(addr + (size - 1)), + int(addr), + int(addr + (size - 1)), ptr['name'].string(), klass, ptr, -- 1.9.1