From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4rbJ-0007sU-5s for qemu-devel@nongnu.org; Fri, 04 Dec 2015 09:44:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4rbE-0002XW-Ly for qemu-devel@nongnu.org; Fri, 04 Dec 2015 09:44:44 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:39531 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4rbE-0002XI-9f for qemu-devel@nongnu.org; Fri, 04 Dec 2015 09:44:40 -0500 From: "Denis V. Lunev" Date: Fri, 4 Dec 2015 17:44:30 +0300 Message-Id: <1449240275-26196-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, qemu-devel@nongnu.org, Markus Armbruster , Amit Shah , "Denis V. Lunev" EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HMP for this operation. This create snapshot/delete snapshot sequence passes silently. The patchset adds QMP wrappers for the purpose. Signed-off-by: "Denis V. Lunev" CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake Changes from v1: - cosmetic fixes suggested by Markus. I pray I have added all of them :) - patch 5 is rewritten completely. Original one was deadbeaf Denis V. Lunev (5): migration: split hmp_savevm to do_savevm and hmp_savevm wrapper qmp: create qmp_savevm command qmp: create qmp_delvm command migration: improve error reporting for hmp_loadvm qmp: create QMP implementation of loadvm command include/sysemu/sysemu.h | 2 +- migration/savevm.c | 100 +++++++++++++++++++++++++++++++----------------- monitor.c | 7 +++- qapi-schema.json | 39 +++++++++++++++++++ qmp-commands.hx | 71 ++++++++++++++++++++++++++++++++++ vl.c | 5 ++- 6 files changed, 185 insertions(+), 39 deletions(-)