qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Miao Yan <yanmiaobest@gmail.com>
To: jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org,
	eblake@redhat.com, armbru@redhat.com
Subject: [Qemu-devel]  [PATCH v2 0/3] fix debug macro pattern for vmxnet3
Date: Sat,  5 Dec 2015 00:54:59 -0800	[thread overview]
Message-ID: <1449305702-2122-1-git-send-email-yanmiaobest@gmail.com> (raw)

This patchset fixes debug macro pattern for vmxnet3. The old style uses
 #ifdef...#else...#endif to define debug macros, as a result
the format string inside the macro will never be checked 
(debug not turned on by default) and is likely to cause build
errors in the future when enabled.
 
Note patch 1/3 "fix a build error when enabling debug output"
has already been applied to -net tree by Jason Wang as 
a separate patch, it's included here for completeness because the other two 
depend on it.

Miao Yan (3):
  net/vmxnet3.c: fix a build error when enabling debug output
  net/vmxnet3: fix debug macro pattern for vmxnet3
  net/vmxnet3: remove redundant VMW_SHPRN(...) definition

 hw/net/vmware_utils.h |   5 +-
 hw/net/vmxnet3.c      |   2 +-
 hw/net/vmxnet_debug.h | 139 +++++++++++++++++++++++++++++++-------------------
 3 files changed, 88 insertions(+), 58 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-12-05  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05  8:54 Miao Yan [this message]
2015-12-05  8:55 ` [Qemu-devel] [PATCH v2 1/3] net/vmxnet3.c: fix a build error when enabling debug output Miao Yan
2015-12-05 16:32   ` Eric Blake
2015-12-05  8:55 ` [Qemu-devel] [PATCH v2 2/3] net/vmxnet3: fix debug macro pattern for vmxnet3 Miao Yan
2015-12-07  2:47   ` Jason Wang
2015-12-07 22:04     ` Eric Blake
2015-12-08  2:53       ` Miao Yan
2015-12-11  3:12       ` Jason Wang
2015-12-05  8:55 ` [Qemu-devel] [PATCH v2 3/3] net/vmxnet3: remove redundant VMW_SHPRN(...) definition Miao Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449305702-2122-1-git-send-email-yanmiaobest@gmail.com \
    --to=yanmiaobest@gmail.com \
    --cc=armbru@redhat.com \
    --cc=dmitry@daynix.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).