qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: ehabkost@redhat.com, agraf@suse.de, aik@ozlabs.ru,
	mdroth@linux.vnet.ibm.com
Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCHv2 05/10] Move SET_MACHINE_COMPAT macro to boards.h
Date: Mon,  7 Dec 2015 14:34:35 +1100	[thread overview]
Message-ID: <1449459280-14983-6-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1449459280-14983-1-git-send-email-david@gibson.dropbear.id.au>

pc.h defines a SET_MACHINE_COMPAT macro to make setting up compat_props
for the various PC machine versions less verbose.  There's nothing
inherently PC specific about it, though, so move it to boards.h where other
versioned machine types (like pseries-*) can use it.

While we're doing that, change it's indentation to be a bit more regular.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/hw/boards.h  | 9 +++++++++
 include/hw/i386/pc.h | 8 --------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/include/hw/boards.h b/include/hw/boards.h
index 5da4fb0..9bf4ec8 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -153,4 +153,13 @@ struct MachineState {
     } \
     machine_init(machine_initfn##_register_types)
 
+#define SET_MACHINE_COMPAT(m, COMPAT) \
+    do {                              \
+        static GlobalProperty props[] = {       \
+            COMPAT                              \
+            { /* end of list */ }               \
+        };                                      \
+        (m)->compat_props = props;              \
+    } while (0)
+
 #endif
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 854c330..071a0d7 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -795,13 +795,5 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
     } \
     machine_init(pc_machine_init_##suffix)
 
-#define SET_MACHINE_COMPAT(m, COMPAT) do { \
-    static GlobalProperty props[] = { \
-        COMPAT \
-        { /* end of list */ } \
-    }; \
-    (m)->compat_props = props; \
-} while (0)
-
 extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id);
 #endif
-- 
2.5.0

  parent reply	other threads:[~2015-12-07  3:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  3:34 [Qemu-devel] [PATCHv2 00/10] Clean up pseries machine versioning David Gibson
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 01/10] pseries: Remove redundant setting of mc->name for pseries-2.5 machine David Gibson
2015-12-09  3:31   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 02/10] pseries: Rearrange versioned machine type code David Gibson
2015-12-07 10:21   ` Thomas Huth
2015-12-09  2:53     ` David Gibson
2015-12-09  3:43   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 03/10] pseries: Remove redundant calls to spapr_machine_initfn() David Gibson
2015-12-07 10:25   ` Thomas Huth
2015-12-09  3:32   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 04/10] pseries: Remove versions from mc->desc David Gibson
2015-12-07 10:07   ` Thomas Huth
2015-12-09  3:32   ` Alexey Kardashevskiy
2015-12-07  3:34 ` David Gibson [this message]
2015-12-09  3:32   ` [Qemu-devel] [PATCHv2 05/10] Move SET_MACHINE_COMPAT macro to boards.h Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 06/10] pseries: Use SET_MACHINE_COMPAT David Gibson
2015-12-07 10:27   ` Thomas Huth
2015-12-09  3:32   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 07/10] pseries: DEFINE_SPAPR_MACHINE David Gibson
2015-12-08  2:38   ` [Qemu-devel] [Qemu-ppc] " Sam Bobroff
2015-12-09  3:30     ` Alexey Kardashevskiy
2015-12-09  3:38       ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 08/10] pseries: Restructure class_options functions David Gibson
2015-12-09  3:36   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 09/10] pseries: Improve setting of default machine version David Gibson
2015-12-09  3:37   ` Alexey Kardashevskiy
2015-12-07  3:34 ` [Qemu-devel] [PATCHv2 10/10] pseries: Add pseries-2.6 machine type David Gibson
2015-12-09  3:37   ` Alexey Kardashevskiy
2015-12-09  4:37 ` [Qemu-devel] [PATCHv2 00/10] Clean up pseries machine versioning David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449459280-14983-6-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=ehabkost@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).