From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, famz@redhat.com,
stefanha@redhat.com, Cornelia Huck <cornelia.huck@de.ibm.com>,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread
Date: Mon, 7 Dec 2015 16:50:01 +0100 [thread overview]
Message-ID: <1449503401-19414-1-git-send-email-cornelia.huck@de.ibm.com> (raw)
For x-data-plane=true, we create an iothread automatically for
compatibility. Commit d21e877 ("iothread: include id in thread name")
exposed that this iothread missed correct parenthood: fix this.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/block/dataplane/virtio-blk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index c42ddeb..c7e5668 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
object_initialize(&s->internal_iothread_obj,
sizeof(s->internal_iothread_obj),
TYPE_IOTHREAD);
+ object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
+ OBJECT(&s->internal_iothread_obj),
+ &error_abort);
user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
s->iothread = &s->internal_iothread_obj;
}
--
2.3.9
next reply other threads:[~2015-12-07 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 15:50 Cornelia Huck [this message]
2015-12-07 16:27 ` [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread Cornelia Huck
2015-12-07 16:33 ` Peter Maydell
2015-12-07 16:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449503401-19414-1-git-send-email-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).