From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a69NB-0004J2-Qq for qemu-devel@nongnu.org; Mon, 07 Dec 2015 22:55:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a69NA-0003Wb-L4 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 22:55:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a69NA-0003WF-Ap for qemu-devel@nongnu.org; Mon, 07 Dec 2015 22:55:28 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E224B3B757 for ; Tue, 8 Dec 2015 03:55:27 +0000 (UTC) From: Eric Blake Date: Mon, 7 Dec 2015 20:54:56 -0700 Message-Id: <1449546921-6378-7-git-send-email-eblake@redhat.com> In-Reply-To: <1449546921-6378-1-git-send-email-eblake@redhat.com> References: <1449546921-6378-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v7 06/31] balloon: Improve use of qapi visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, "Michael S. Tsirkin" Rework the control flow of balloon_stats_get_all() to make it easier for a later patch to split visit_end_struct(). Also switch to the uint64 visitor to match the data type. Signed-off-by: Eric Blake --- v7: place earlier in series v6: new patch, split from RFC on v5 7/46 --- hw/virtio/virtio-balloon.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 9671635..1ce987a 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -130,10 +130,13 @@ static void balloon_stats_get_all(Object *obj, struct Visitor *v, if (err) { goto out_end; } - for (i = 0; !err && i < VIRTIO_BALLOON_S_NR; i++) { - visit_type_int64(v, (int64_t *) &s->stats[i], balloon_stat_names[i], - &err); + for (i = 0; i < VIRTIO_BALLOON_S_NR; i++) { + visit_type_uint64(v, &s->stats[i], balloon_stat_names[i], &err); + if (err) { + goto out_nested; + } } +out_nested: error_propagate(errp, err); err = NULL; visit_end_struct(v, &err); -- 2.4.3