qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Karcher <karcher@physik.fu-berlin.de>
To: Riku Voipio <riku.voipio@iki.fi>,
	Laurent Vivier <Laurent@Vivier.EU>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation
Date: Wed,  9 Dec 2015 21:40:57 +0100	[thread overview]
Message-ID: <1449693657-5350-1-git-send-email-karcher@physik.fu-berlin.de> (raw)

do_rt_sigreturn forgets to initialize the signal mask variable before
trying to use it to restore the mask, so the signal mask is undefined
after do_rt_sigreturn. This bug has been in all the time since
7181155d when do_rt_sigreturn was implemented for m68k.
---
 linux-user/signal.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index e03ed60..ae1014b 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -5260,11 +5260,14 @@ long do_rt_sigreturn(CPUM68KState *env)
     abi_ulong frame_addr = env->aregs[7] - 4;
     target_sigset_t target_set;
     sigset_t set;
-    int d0;
+    int d0, i;
 
     if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
         goto badframe;
 
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {
+        target_set.sig[i] = frame->uc.tuc_sigmask.sig[i];
+    }
     target_to_host_sigset_internal(&set, &target_set);
     do_sigprocmask(SIG_SETMASK, &set, NULL);
 
-- 
2.1.4

             reply	other threads:[~2015-12-09 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 20:40 Michael Karcher [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-09 20:54 [Qemu-devel] [PATCH 0/1] m68k linux user-space emulation fix (with sign-off this time) Michael Karcher
2015-12-09 20:54 ` [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation Michael Karcher
2015-12-09 22:03   ` Laurent Vivier
2015-12-12  9:55     ` Michael Karcher
2015-12-12 10:35       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449693657-5350-1-git-send-email-karcher@physik.fu-berlin.de \
    --to=karcher@physik.fu-berlin.de \
    --cc=Laurent@Vivier.EU \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).