From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xxB-0007YD-Cq for qemu-devel@nongnu.org; Thu, 10 Dec 2015 04:56:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6xx7-0007ck-UD for qemu-devel@nongnu.org; Thu, 10 Dec 2015 04:56:01 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:44353 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xx7-0007bi-In for qemu-devel@nongnu.org; Thu, 10 Dec 2015 04:55:57 -0500 From: "Denis V. Lunev" Date: Thu, 10 Dec 2015 12:55:48 +0300 Message-Id: <1449741348-7198-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH 1/1] qcow2: insert assert into qcow2_get_specific_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , Max Reitz , qemu-devel@nongnu.org, Roman Kagan s->qcow_version is always set to 2 or 3. Let's assert if this is wrong. Signed-off-by: Denis V. Lunev CC: Roman Kagan CC: Max Reitz CC: Kevin Wolf --- block/qcow2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 88f56c8..b285014 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2757,6 +2757,10 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs) .has_corrupt = true, .refcount_bits = s->refcount_bits, }; + } else { + /* if this assertion fails, this probably means a new version was + * added without having it covered here */ + assert(false); } return spec_info; -- 2.1.4