qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: armbru@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com
Cc: lvivier@redhat.com, thuth@redhat.com, agraf@suse.de,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 00/11] Error handling cleanups for pseries machine type
Date: Fri, 11 Dec 2015 11:11:14 +1100	[thread overview]
Message-ID: <1449792685-17000-1-git-send-email-david@gibson.dropbear.id.au> (raw)

The code for the pseries machine type is a bit of a hodge podge in
terms of error handling.  Some parts use the modern error handling
APIs, others use old explicit fprintf()s and exit()s.

This patch makes a start on cleaning this up, modernizing the error
handling in a number of places to use the current APIs.

After this series there are still quite a lot of places using explicit
fprintf()s and exit()s, particularly in the device tree handling code.
I hope to get to those eventually, but in the meantime, something is
better than nothing, right?

RESEND: Sorry, forgot to CC the lists the first time around.
Apologies to those who get it twice.

David Gibson (11):
  ppc: Cleanup error handling in ppc_set_compat()
  pseries: Cleanup error handling of spapr_cpu_init()
  pseries: Clean up hash page table allocation error handling
  pseries: Clean up error handling in spapr_validate_node_memory()
  pseries: Cleanup error handling in spapr_vga_init()
  pseries: Improve error handling in find_unknown_sysbus_device()
  pseries: Cleanup error handling in spapr_kvm_type()
  pseries: Clean up error handling in spapr_rtas_register()
  pseries: Clean up error handling in xics_system_init()
  pseries: Clean up error handling in ppc_spapr_init()
  pseries: Clean up error reporting in htab migration functions

 hw/ppc/spapr.c              | 174 ++++++++++++++++++++++++--------------------
 hw/ppc/spapr_hcall.c        |  10 +--
 hw/ppc/spapr_rtas.c         |   9 +--
 target-ppc/cpu.h            |   2 +-
 target-ppc/translate_init.c |  13 ++--
 5 files changed, 111 insertions(+), 97 deletions(-)

-- 
2.5.0

             reply	other threads:[~2015-12-11  0:10 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  0:11 David Gibson [this message]
2015-12-11  0:11 ` [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat() David Gibson
2015-12-11  9:17   ` Thomas Huth
2015-12-11 13:58   ` Eric Blake
2015-12-14  0:54     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 02/11] pseries: Cleanup error handling of spapr_cpu_init() David Gibson
2015-12-11  8:45   ` Bharata B Rao
2015-12-14  1:01     ` David Gibson
2015-12-11 14:54   ` Eric Blake
2015-12-14  1:04     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling David Gibson
2015-12-11  8:40   ` Bharata B Rao
2015-12-14  1:11     ` David Gibson
2015-12-11 15:01   ` Eric Blake
2015-12-14  1:11     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 04/11] pseries: Clean up error handling in spapr_validate_node_memory() David Gibson
2015-12-11  8:56   ` Bharata B Rao
2015-12-11  0:11 ` [Qemu-devel] [PATCH 05/11] pseries: Cleanup error handling in spapr_vga_init() David Gibson
2015-12-11  9:35   ` Thomas Huth
2015-12-14  1:13     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 06/11] pseries: Improve error handling in find_unknown_sysbus_device() David Gibson
2015-12-11  9:49   ` Thomas Huth
2015-12-14  1:20     ` David Gibson
2015-12-11 15:15   ` Eric Blake
2015-12-14  1:21     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 07/11] pseries: Cleanup error handling in spapr_kvm_type() David Gibson
2015-12-11 10:01   ` Thomas Huth
2015-12-14  1:24     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 08/11] pseries: Clean up error handling in spapr_rtas_register() David Gibson
2015-12-11 10:06   ` Thomas Huth
2015-12-11  0:11 ` [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_system_init() David Gibson
2015-12-11 10:08   ` Thomas Huth
2015-12-14  1:26     ` David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 10/11] pseries: Clean up error handling in ppc_spapr_init() David Gibson
2015-12-11  0:11 ` [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions David Gibson
2015-12-11 10:12   ` Thomas Huth
2015-12-11 15:22   ` Eric Blake
2015-12-14  1:28     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449792685-17000-1-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=armbru@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).