From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7BIa-0001qJ-3C for qemu-devel@nongnu.org; Thu, 10 Dec 2015 19:11:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7BIW-0006Vv-5G for qemu-devel@nongnu.org; Thu, 10 Dec 2015 19:10:59 -0500 From: David Gibson Date: Fri, 11 Dec 2015 11:11:21 +1100 Message-Id: <1449792685-17000-8-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1449792685-17000-1-git-send-email-david@gibson.dropbear.id.au> References: <1449792685-17000-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PATCH 07/11] pseries: Cleanup error handling in spapr_kvm_type() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com Cc: lvivier@redhat.com, thuth@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, David Gibson Use error_setg() and &error_fatal instead of an explicit exit(). Signed-off-by: David Gibson --- hw/ppc/spapr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fd16db4..546d2f5 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2035,8 +2035,8 @@ static int spapr_kvm_type(const char *vm_type) return 2; } - error_report("Unknown kvm-type specified '%s'", vm_type); - exit(1); + error_setg(&error_fatal, "Unknown kvm-type specified '%s'", vm_type); + return 0; } /* -- 2.5.0