From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7YwL-0006Kg-CO for qemu-devel@nongnu.org; Fri, 11 Dec 2015 20:25:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7YwK-0000Pa-8f for qemu-devel@nongnu.org; Fri, 11 Dec 2015 20:25:37 -0500 From: John Snow Date: Fri, 11 Dec 2015 20:25:27 -0500 Message-Id: <1449883528-26477-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1449883528-26477-1-git-send-email-jsnow@redhat.com> References: <1449883528-26477-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, John Snow , qemu-devel@nongnu.org, mreitz@redhat.com ...But only if we have the backing_filename. It means something Scary happened and we can't really be quite exactly sure if we can trust the backing_filename. Signed-off-by: John Snow --- qemu-img.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 033011c..272bb0b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2040,7 +2040,10 @@ static ImageInfoList *collect_image_info_list(const char *filename, if (info->has_full_backing_filename) { filename = info->full_backing_filename; } else if (info->has_backing_filename) { - filename = info->backing_filename; + error_report("Could not determine absolute backing filename," + " but backing filename '%s' present", + info->backing_filename); + goto err; } if (info->has_backing_filename_format) { fmt = info->backing_filename_format; -- 2.4.3