From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 00/11] Avoid always-active qemu_log calls
Date: Sat, 12 Dec 2015 11:36:16 +0100 [thread overview]
Message-ID: <1449916587-18312-1-git-send-email-pbonzini@redhat.com> (raw)
qemu_log calls should generally be wrapped by DEBUG_* preprocessor
symbols or (preferred) qemu_log_mask should be used instead. This
avoids that the upcoming integration of logging and tracing prints
some log messages to stderr unconditionally.
Similarly, most occurrences of qemu_log_enabled() should be changed
to qemu_log_mask(). One exception is when these always-active qemu_log
calls are coupled with printfs to stdout or stderr. These should be
skipped if stderr is _already_ the logging destination, and the
series thus introduces a new predicate qemu_log_separate() to
replace qemu_log_enabled() in some cases.
This series removes all the instances that I could find of these
problems.
Paolo
Paolo Bonzini (11):
qemu-log: introduce qemu_log_separate
alpha: convert "naked" qemu_log to tracepoint
cris: avoid "naked" qemu_log
microblaze: avoid "naked" qemu_log
s390x: avoid "naked" qemu_log
ppc: cleanup logging
tricore: avoid "naked" qemu_log
xtensa: avoid "naked" qemu_log
user: introduce "-d page"
linux-user: avoid "naked" qemu_log
linux-user: convert DEBUG_SIGNAL logging to tracepoints
bsd-user/main.c | 4 +-
bsd-user/signal.c | 2 -
exec.c | 2 +-
hw/alpha/pci.c | 3 +-
hw/char/etraxfs_ser.c | 2 +-
include/qemu/log.h | 8 +++
linux-user/elfload.c | 8 +--
linux-user/main.c | 75 ++++++++++++---------------
linux-user/signal.c | 118 +++++++++++++++++++++---------------------
qemu-log.c | 2 +
target-cris/helper.h | 1 -
target-cris/op_helper.c | 5 --
target-cris/translate.c | 8 +--
target-cris/translate_v10.c | 2 +-
target-microblaze/helper.c | 2 +-
target-microblaze/mmu.c | 20 +++----
target-microblaze/op_helper.c | 8 +--
target-microblaze/translate.c | 2 +-
target-ppc/excp_helper.c | 8 +--
target-ppc/mmu-hash32.c | 12 +----
target-ppc/mmu-hash64.c | 9 +---
target-ppc/mmu_helper.c | 15 +++---
target-ppc/timebase_helper.c | 10 ++--
target-ppc/translate.c | 62 +++++++++++-----------
target-s390x/cc_helper.c | 2 +-
target-s390x/helper.c | 2 +-
target-s390x/misc_helper.c | 2 +-
target-s390x/mmu_helper.c | 2 +-
target-tricore/helper.c | 4 +-
target-xtensa/gdbstub.c | 8 +--
target-xtensa/helper.c | 4 +-
target-xtensa/op_helper.c | 20 +++----
target-xtensa/translate.c | 28 +++++-----
target-xtensa/xtensa-semi.c | 2 +-
trace-events | 14 +++++
35 files changed, 237 insertions(+), 239 deletions(-)
--
2.5.0
next reply other threads:[~2015-12-12 10:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 10:36 Paolo Bonzini [this message]
2015-12-12 10:36 ` [Qemu-devel] [PATCH 01/11] qemu-log: introduce qemu_log_separate Paolo Bonzini
2015-12-12 10:36 ` [Qemu-devel] [PATCH 02/11] alpha: convert "naked" qemu_log to tracepoint Paolo Bonzini
2015-12-16 16:59 ` Richard Henderson
2015-12-12 10:36 ` [Qemu-devel] [PATCH 03/11] cris: avoid "naked" qemu_log Paolo Bonzini
2015-12-17 13:32 ` Edgar E. Iglesias
2015-12-12 10:36 ` [Qemu-devel] [PATCH 04/11] microblaze: " Paolo Bonzini
2015-12-17 13:34 ` Edgar E. Iglesias
2015-12-12 10:36 ` [Qemu-devel] [PATCH 05/11] s390x: " Paolo Bonzini
2015-12-12 10:36 ` [Qemu-devel] [PATCH 06/11] ppc: cleanup logging Paolo Bonzini
2015-12-14 0:24 ` David Gibson
2015-12-12 10:36 ` [Qemu-devel] [PATCH 07/11] tricore: avoid "naked" qemu_log Paolo Bonzini
2015-12-12 19:47 ` Bastian Koppelmann
2015-12-12 20:15 ` Peter Maydell
2015-12-12 10:36 ` [Qemu-devel] [PATCH 08/11] xtensa: " Paolo Bonzini
2015-12-12 10:36 ` [Qemu-devel] [PATCH 09/11] user: introduce "-d page" Paolo Bonzini
2015-12-12 10:36 ` [Qemu-devel] [PATCH 10/11] linux-user: avoid "naked" qemu_log Paolo Bonzini
2015-12-12 15:04 ` Laurent Vivier
2015-12-12 10:39 ` [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints Paolo Bonzini
2015-12-12 15:08 ` Laurent Vivier
2015-12-15 6:59 ` Thomas Huth
2015-12-15 13:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449916587-18312-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).