From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Ue8-0007BB-D1 for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:02:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8Ue7-00060u-1a for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:02:40 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:59143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Ue6-0005zS-SP for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:02:38 -0500 From: Peter Maydell Date: Mon, 14 Dec 2015 15:02:36 +0000 Message-Id: <1450105357-8516-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH for-2.5??] configure: Fix shell syntax to placate OpenBSD's pdksh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org Unfortunately the OpenBSD pdksh does not like brackets inside the right part of a ${variable+word} parameter expansion: $ echo "${a+($b)}" ksh: ${a+($b)}": bad substitution though both bash and dash accept them. In any case this line was causing odd output in the case where nettle is not present: nettle no () (because if nettle is not present then $nettle will be "no", not a null string or unset). Rewrite it to just use an if. This bug was originally introduced in becaeb726 and was present in the 2.4.0 release. Fixes: https://bugs.launchpad.net/qemu/+bug/1525682 Reported-by: Dmitrij D. Czarkoff Signed-off-by: Peter Maydell --- This fixes a problem where configure just falls over on OpenBSD, but on the other hand it is not a regression since 2.4.0... Opinions on whether we should put it in 2.5 as a last minute thing welcome. configure | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b9552fd..6ca6c64 100755 --- a/configure +++ b/configure @@ -4758,7 +4758,11 @@ echo "GTK GL support $gtk_gl" echo "GNUTLS support $gnutls" echo "GNUTLS hash $gnutls_hash" echo "libgcrypt $gcrypt" -echo "nettle $nettle ${nettle+($nettle_version)}" +if test "$nettle" = "yes"; then + echo "nettle $nettle ($nettle_version)" +else + echo "nettle $nettle" +fi echo "libtasn1 $tasn1" echo "VTE support $vte" echo "curses support $curses" -- 1.9.1