From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8l5c-0005pZ-8c for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:36:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8l5X-0003Ge-8o for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:36:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8l5X-0003Ga-2v for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:36:03 -0500 From: Thomas Huth Date: Tue, 15 Dec 2015 09:35:59 +0100 Message-Id: <1450168559-9181-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , qemu-devel@nongnu.org Cc: Jason Wang We don't want to support the legacy -tftp, -bootp, -smb and -net channel options forever. So let's start telling the users that they will go away in a future version. Signed-off-by: Thomas Huth --- net/slirp.c | 3 +++ os-posix.c | 3 +++ vl.c | 6 ++++++ 3 files changed, 12 insertions(+) diff --git a/net/slirp.c b/net/slirp.c index f505570..65e3766 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -784,6 +784,9 @@ int net_slirp_parse_legacy(QemuOptsList *opts_list, const char *optarg, int *ret return 0; } + error_report("The -net channel option is deprecated and " + "will be removed in a future version."); + /* handle legacy -net channel,port:chr */ optarg += strlen("channel,"); diff --git a/os-posix.c b/os-posix.c index e4da406..3f62f7c 100644 --- a/os-posix.c +++ b/os-posix.c @@ -40,6 +40,7 @@ #include "net/slirp.h" #include "qemu-options.h" #include "qemu/rcu.h" +#include "qemu/error-report.h" #ifdef CONFIG_LINUX #include @@ -139,6 +140,8 @@ void os_parse_cmd_args(int index, const char *optarg) switch (index) { #ifdef CONFIG_SLIRP case QEMU_OPTION_smb: + error_report("The -smb option is deprecated and " + "will be removed in a future version."); if (net_slirp_smb(optarg) < 0) exit(1); break; diff --git a/vl.c b/vl.c index 4211ff1..fa829c0 100644 --- a/vl.c +++ b/vl.c @@ -3314,12 +3314,18 @@ int main(int argc, char **argv, char **envp) #endif #ifdef CONFIG_SLIRP case QEMU_OPTION_tftp: + error_report("The -tftp option is deprecated and " + "will be removed in a future version."); legacy_tftp_prefix = optarg; break; case QEMU_OPTION_bootp: + error_report("The -bootp option is deprecated and " + "will be removed in a future version."); legacy_bootp_filename = optarg; break; case QEMU_OPTION_redir: + error_report("The -redir option is deprecated and " + "will be removed in a future version."); if (net_slirp_redir(optarg) < 0) exit(1); break; -- 1.8.3.1