From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8mxc-0005bP-Cl for qemu-devel@nongnu.org; Tue, 15 Dec 2015 05:36:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8mxZ-0006HM-7c for qemu-devel@nongnu.org; Tue, 15 Dec 2015 05:36:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8mxZ-0006HH-2G for qemu-devel@nongnu.org; Tue, 15 Dec 2015 05:35:57 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A1EC33C234 for ; Tue, 15 Dec 2015 10:35:56 +0000 (UTC) Message-ID: <1450175753.24446.2.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 15 Dec 2015 11:35:53 +0100 In-Reply-To: <1447872780-2229-1-git-send-email-berrange@redhat.com> References: <1447872780-2229-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v1 0/3] Convert VNC server to QIOChannel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On Mi, 2015-11-18 at 18:52 +0000, Daniel P. Berrange wrote: > This is an update of patches previously shown in an RFC posting >=20 > RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.htm= l >=20 > This series depends on the previously posted series: >=20 > "[PATCH v3 0/9] Introduce I/O channels framework" >=20 > This short series converts the VNC server to use the new > QIOChannel framework. This removes all the websocket protocol > code from the VNC server and further simplifies the TLS > handling in the VNC server >=20 > The conversion has been tested against the virt-viewer/ > remote-viewer programs in the various TLS modes, and also > against the noVNC proxy websockets client with and without > TLS support. Looks good to me. In case you want send the pull request yourself: Reviewed-by: Gerd Hoffmann Otherwise ping me when the depending patch series is merged. thanks, Gerd