From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8o40-0002P2-Gy for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:46:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8o3v-0006xs-GN for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:46:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8o3v-0006xS-BC for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:46:35 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 84433A37A7 for ; Tue, 15 Dec 2015 11:46:34 +0000 (UTC) From: Thomas Huth Date: Tue, 15 Dec 2015 12:46:32 +0100 Message-Id: <1450179992-15959-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Jason Wang We likely don't want to maintain the legacy -net options forever, so let's start informing the users that this option will be removed in a future version. However, there are two cases where we should not spill out a message yet: First is the "-net nic" option which might still be required to configure on-board NICs that can not be handled via "-netdev" yet, and second is the "-net user" default option that is created automatically when no other networking option has been specified. Signed-off-by: Thomas Huth --- net/net.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/net.c b/net/net.c index ade6051..2593961 100644 --- a/net/net.c +++ b/net/net.c @@ -1006,6 +1006,12 @@ static int net_client_init1(const void *object, int is_netdev, Error **errp) return -1; } + if (opts->type != NET_CLIENT_OPTIONS_KIND_NIC && + (!default_net || opts->type != NET_CLIENT_OPTIONS_KIND_USER)) { + error_report("Deprecated net option - " + "this will be removed in a future version!"); + } + if (!net_client_init_fun[opts->type]) { error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "type", "a net backend type (maybe it is not compiled " -- 1.8.3.1