qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Tim Sander <tim.sander@hbm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC] i2c: Add AT24Cxx EEPROM model
Date: Thu, 17 Dec 2015 17:18:03 +0100	[thread overview]
Message-ID: <1450369083.5981.19.camel@redhat.com> (raw)
In-Reply-To: <1804358.aPeCirA3Fj@dabox>

  Hi,

> Some devices react on multiple addresses. To emulate this, we could
> register them multiple times, but that is cumbersome. The AT24C16, e.g.
> listens on 8 different addresses.
> 
> Instead, introduce a device address mask that is applied on the
> transmitted address before matching it against the stored one. Moreover,
> the transmitted address is passed as additional parameter to the event
> callback of the device.

This interface change ...

> This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to
> 1024Kbit are supported. Each EEPROM is backed by a block device. Its
> size can be explicitly specified by selecting the exact device type
> (required for sizes < 512, the blockdev sector size) or implicitly by
> providing a block device image of the corresponding size. Device
> addresses are built from the device number property. Write protection
> can be configured by declaring the block device read-only.

... and this new device should be two separate patches (but best sent as
patch series to make clear why the interface change is needed).

cheers,
  Gerd

      reply	other threads:[~2015-12-17 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 13:09 [Qemu-devel] [PATCH RFC] i2c: Add AT24Cxx EEPROM model Tim Sander
2015-12-17 16:18 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450369083.5981.19.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tim.sander@hbm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).