From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9bWb-00079O-34 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:35:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9bWZ-0003t2-JL for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:35:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9bWZ-0003sb-Dy for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:35:27 -0500 From: Markus Armbruster Date: Thu, 17 Dec 2015 17:35:21 +0100 Message-Id: <1450370121-5768-14-git-send-email-armbru@redhat.com> In-Reply-To: <1450370121-5768-1-git-send-email-armbru@redhat.com> References: <1450370121-5768-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Stefano Stabellini Cc: Stefano Stabellini Cc: xen-devel@lists.xensource.com Signed-off-by: Markus Armbruster --- xen-hvm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen-hvm.c b/xen-hvm.c index 3d78a0c..2a93390 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms, void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) { + /* FIXME caller ram_block_add() wants error_setg() on failure */ unsigned long nr_pfn; xen_pfn_t *pfn_list; int i; @@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data) int xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) { + /* + * FIXME Returns -1 without cleaning up on some errors (harmless + * as long as the caller exit()s on error), dies with hw_error() + * on others. hw_error() isn't approprate here. Should probably + * simply exit() on all errors. + */ int i, rc; xen_pfn_t ioreq_pfn; xen_pfn_t bufioreq_pfn; -- 2.4.3