From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9x4B-0005J6-Ii for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:35:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9x48-000314-Mj for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:35:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9x48-00030v-IF for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:35:32 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3A57533569E for ; Fri, 18 Dec 2015 15:35:32 +0000 (UTC) From: Markus Armbruster Date: Fri, 18 Dec 2015 16:35:09 +0100 Message-Id: <1450452927-8346-7-git-send-email-armbru@redhat.com> In-Reply-To: <1450452927-8346-1-git-send-email-armbru@redhat.com> References: <1450452927-8346-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 06/24] block: Clean up "Could not create temporary overlay" error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org bdrv_create() sets an error and returns -errno on failure. When the latter is interesting, the error is created with error_setg_errno(). bdrv_append_temp_snapshot() uses the error's message to create a new one with error_setg_errno(). This adds a strerror() that is either uninteresting or duplicate. Use error_setg() instead. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- block.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 9971976..4b40cb2 100644 --- a/block.c +++ b/block.c @@ -1336,9 +1336,8 @@ int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, Error **errp) ret = bdrv_create(&bdrv_qcow2, tmp_filename, opts, &local_err); qemu_opts_del(opts); if (ret < 0) { - error_setg_errno(errp, -ret, "Could not create temporary overlay " - "'%s': %s", tmp_filename, - error_get_pretty(local_err)); + error_setg(errp, "Could not create temporary overlay '%s': %s", + tmp_filename, error_get_pretty(local_err)); error_free(local_err); goto out; } -- 2.4.3