qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 2/8] ivshmem: remove redundant assignment, fix crash with msi=off
Date: Mon, 21 Dec 2015 12:30:38 +0100	[thread overview]
Message-ID: <1450697444-30119-3-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1450697444-30119-1-git-send-email-marcandre.lureau@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in
this case)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/misc/ivshmem.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 7d14222..dcfc8cc 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -355,12 +355,9 @@ static CharDriverState* create_eventfd_chr_device(IVShmemState *s,
                                                   int vector)
 {
     /* create a event character device based on the passed eventfd */
-    PCIDevice *pdev = PCI_DEVICE(s);
     int eventfd = event_notifier_get_fd(n);
     CharDriverState *chr;
 
-    s->msi_vectors[vector].pdev = pdev;
-
     chr = qemu_chr_open_eventfd(eventfd);
 
     if (chr == NULL) {
-- 
2.5.0

  parent reply	other threads:[~2015-12-21 11:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 11:30 [Qemu-devel] [PATCH 0/8] ivshmem: test msi=off, remove CharDriver marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 1/8] ivshmem: no need for opaque argument marcandre.lureau
2015-12-21 11:30 ` marcandre.lureau [this message]
2015-12-21 11:30 ` [Qemu-devel] [PATCH 3/8] ivshmem-test: leak fixes marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 4/8] libqos: remove some leaks marcandre.lureau
2016-01-29 15:43   ` Markus Armbruster
2016-02-01 13:59     ` Marc-André Lureau
2016-02-01 16:45       ` Markus Armbruster
2016-02-02  8:38         ` Markus Armbruster
2015-12-21 11:30 ` [Qemu-devel] [PATCH 5/8] ivshmem-test: test both msi & irq cases marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 6/8] ivshmem: generalize ivshmem_setup_interrupts marcandre.lureau
2016-01-29 15:59   ` Markus Armbruster
2016-02-01 14:50     ` Marc-André Lureau
2016-02-01 16:50       ` Markus Armbruster
2015-12-21 11:30 ` [Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver marcandre.lureau
2016-01-29 16:23   ` Markus Armbruster
2016-02-01 15:22     ` Marc-André Lureau
2016-02-01 16:49       ` Markus Armbruster
2016-02-22  9:28         ` Markus Armbruster
2015-12-21 11:30 ` [Qemu-devel] [PATCH 8/8] char: remove qemu_chr_open_eventfd marcandre.lureau
2016-01-07 15:52 ` [Qemu-devel] [PATCH 0/8] ivshmem: test msi=off, remove CharDriver Marc-André Lureau
2016-01-29 10:12   ` Marc-André Lureau
2016-01-29 15:25   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450697444-30119-3-git-send-email-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).