From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message
Date: Mon, 21 Dec 2015 16:06:54 +0000 [thread overview]
Message-ID: <1450714014-16849-7-git-send-email-berrange@redhat.com> (raw)
In-Reply-To: <1450714014-16849-1-git-send-email-berrange@redhat.com>
When reporting an incorrect key length for a cipher, we
mixed up the actual vs expected arguments.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
crypto/cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/cipher.c b/crypto/cipher.c
index e92d49a..a69ff5e 100644
--- a/crypto/cipher.c
+++ b/crypto/cipher.c
@@ -89,7 +89,7 @@ qcrypto_cipher_validate_key_length(QCryptoCipherAlgorithm alg,
if (alg_key_len[alg] != nkey) {
error_setg(errp, "Cipher key length %zu should be %zu",
- alg_key_len[alg], nkey);
+ nkey, alg_key_len[alg]);
return false;
}
return true;
--
2.5.0
next prev parent reply other threads:[~2015-12-21 16:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 16:06 [Qemu-devel] [PATCH 0/6] Misc enhancements to crypto APIs Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens Daniel P. Berrange
2015-12-21 16:18 ` Eric Blake
2015-12-23 10:52 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len Daniel P. Berrange
2015-12-21 16:22 ` Eric Blake
2015-12-23 10:52 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 3/6] crypto: move QCryptoHashAlgorithm enum definition into QAPI Daniel P. Berrange
2015-12-21 16:27 ` Eric Blake
2015-12-22 15:50 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions " Daniel P. Berrange
2015-12-21 16:29 ` Eric Blake
2015-12-21 16:06 ` [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules Daniel P. Berrange
2015-12-21 16:32 ` Eric Blake
2015-12-22 15:53 ` Daniel P. Berrange
2015-12-21 16:06 ` Daniel P. Berrange [this message]
2015-12-21 16:33 ` [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450714014-16849-7-git-send-email-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).