From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBDL1-00018c-61 for qemu-devel@nongnu.org; Mon, 21 Dec 2015 22:10:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBDKx-0003kM-5c for qemu-devel@nongnu.org; Mon, 21 Dec 2015 22:10:11 -0500 Received: from m12-18.163.com ([220.181.12.18]:58713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBDKw-0003gw-BQ for qemu-devel@nongnu.org; Mon, 21 Dec 2015 22:10:07 -0500 From: Qinghua Jin Date: Tue, 22 Dec 2015 11:09:31 +0800 Message-Id: <1450753771-5666-1-git-send-email-qhjin_dev@163.com> Subject: [Qemu-devel] [PATCH v3] qmp: return err msg when powerdown a vm when it isn't in running state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Qinghua Jin , Fam Zheng , Markus Armbruster , P J P When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING, it will be ignored by system. So reply a err msg with the situation. Signed-off-by: Qinghua Jin --- This is an update of the patch as per Fam Zheng's suggestion: http://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03949.html qmp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qmp.c b/qmp.c index 0a1fa19..384df56 100644 --- a/qmp.c +++ b/qmp.c @@ -114,8 +114,13 @@ void qmp_system_reset(Error **errp) qemu_system_reset_request(); } -void qmp_system_powerdown(Error **erp) +void qmp_system_powerdown(Error **errp) { + if (!runstate_check(RUN_STATE_RUNNING)) { + error_setg(errp, + "Can not powerdown virtual machine as it is not running"); + return; + } qemu_system_powerdown_request(); } -- 2.5.0