From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBGHZ-00071K-FD for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:18:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBGHY-00065H-Ji for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:18:49 -0500 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:35528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBGHY-000658-EB for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:18:48 -0500 Received: by mail-pa0-x230.google.com with SMTP id jx14so84064616pad.2 for ; Mon, 21 Dec 2015 22:18:48 -0800 (PST) From: Miao Yan Date: Mon, 21 Dec 2015 22:18:23 -0800 Message-Id: <1450765104-26135-4-git-send-email-yanmiaobest@gmail.com> In-Reply-To: <1450765104-26135-1-git-send-email-yanmiaobest@gmail.com> References: <1450765104-26135-1-git-send-email-yanmiaobest@gmail.com> Subject: [Qemu-devel] [PATCH v2 3/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org VMXNET3_CMD_GET_DEV_EXTRA_INFO should return 0 for emulation mode This behavior can be observed by the following steps: 1) run a Linux distro on esxi server 2) modify vmxnet3 Linux driver to read the register: VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DEV_EXTRA_INFO); ret = VMXNET3_READ_BAR1_REG(adapter, VMXNET3_REG_CMD); pr_info("vmxnet3 dev_info: 0x%x\n", ret); The kernel log will have some like the following message: [ 7005.111170] vmxnet3 dev_info: 0x0 Signed-off-by: Miao Yan --- Changes in v2: - update vmxnet3_handle_command not to print error when issuing these commands hw/net/vmxnet3.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index cddbf6d..b8bc360 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1648,6 +1648,10 @@ static void vmxnet3_handle_command(VMXNET3State *s, uint64_t cmd) VMW_CBPRN("Set: Get upper part of device ID"); break; + case VMXNET3_CMD_GET_DEV_EXTRA_INFO: + VMW_CBPRN("Set: Get device extra info"); + break; + default: VMW_CBPRN("Received unknown command: %" PRIx64, cmd); break; @@ -1667,6 +1671,7 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State *s) case VMXNET3_CMD_RESET_DEV: case VMXNET3_CMD_QUIESCE_DEV: case VMXNET3_CMD_GET_QUEUE_STATUS: + case VMXNET3_CMD_GET_DEV_EXTRA_INFO: ret = 0; break; -- 1.9.1