From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBQ5E-0003Sz-Gv for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:46:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBQ5D-0007AC-JS for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:46:44 -0500 From: Kevin Wolf Date: Tue, 22 Dec 2015 17:46:19 +0100 Message-Id: <1450802786-20893-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1450802786-20893-1-git-send-email-kwolf@redhat.com> References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com As long as BDRV_O_INCOMING is set, the image file is only opened so we have a file descriptor for it. We're definitely not supposed to modify the image, it's still owned by the migration source. Signed-off-by: Kevin Wolf --- block/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/io.c b/block/io.c index 841f5b5..e893be8 100644 --- a/block/io.c +++ b/block/io.c @@ -1293,6 +1293,7 @@ static int coroutine_fn bdrv_co_do_pwritev(BlockDriverState *bs, if (bs->read_only) { return -EPERM; } + assert(!(bs->open_flags & BDRV_O_INCOMING)); ret = bdrv_check_byte_request(bs, offset, bytes); if (ret < 0) { @@ -2453,6 +2454,7 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, } else if (bs->read_only) { return -EPERM; } + assert(!(bs->open_flags & BDRV_O_INCOMING)); /* Do nothing if disabled. */ if (!(bs->open_flags & BDRV_O_UNMAP)) { -- 1.8.3.1