From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBQ5G-0003V0-3E for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:46:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBQ5F-0007Aq-5H for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:46:45 -0500 From: Kevin Wolf Date: Tue, 22 Dec 2015 17:46:20 +0100 Message-Id: <1450802786-20893-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1450802786-20893-1-git-send-email-kwolf@redhat.com> References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 04/10] block: Fix error path in bdrv_invalidate_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com We can only clear BDRV_O_INCOMING if the caches were actually invalidated. Signed-off-by: Kevin Wolf --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index 411edbf..554ed64 100644 --- a/block.c +++ b/block.c @@ -3273,12 +3273,14 @@ void bdrv_invalidate_cache(BlockDriverState *bs, Error **errp) bdrv_invalidate_cache(bs->file->bs, &local_err); } if (local_err) { + bs->open_flags |= BDRV_O_INCOMING; error_propagate(errp, local_err); return; } ret = refresh_total_sectors(bs, bs->total_sectors); if (ret < 0) { + bs->open_flags |= BDRV_O_INCOMING; error_setg_errno(errp, -ret, "Could not refresh total sector count"); return; } -- 1.8.3.1