From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBcZ4-00083q-AN for qemu-devel@nongnu.org; Wed, 23 Dec 2015 01:06:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBcZ3-0007Ad-Fy for qemu-devel@nongnu.org; Wed, 23 Dec 2015 01:06:22 -0500 Received: from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:35953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBcZ3-0007AY-AW for qemu-devel@nongnu.org; Wed, 23 Dec 2015 01:06:21 -0500 Received: by mail-pf0-x230.google.com with SMTP id 65so3177808pff.3 for ; Tue, 22 Dec 2015 22:06:21 -0800 (PST) From: Miao Yan Date: Tue, 22 Dec 2015 22:06:09 -0800 Message-Id: <1450850771-42884-4-git-send-email-yanmiaobest@gmail.com> In-Reply-To: <1450850771-42884-1-git-send-email-yanmiaobest@gmail.com> References: <1450850771-42884-1-git-send-email-yanmiaobest@gmail.com> Subject: [Qemu-devel] [PATCH v3 3/5] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org VMXNET3_CMD_GET_DEV_EXTRA_INFO should return 0 for emulation mode This behavior can be observed by the following steps: 1) run a Linux distro on esxi server (5.x+) 2) modify vmxnet3 Linux driver to read the register: VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DEV_EXTRA_INFO); ret = VMXNET3_READ_BAR1_REG(adapter, VMXNET3_REG_CMD); pr_info("vmxnet3 dev_info: 0x%x\n", ret); The kernel log will have some like the following message: [ 7005.111170] vmxnet3 dev_info: 0x0 Signed-off-by: Miao Yan --- Changes in v3: - mention esxi version in commit message hw/net/vmxnet3.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index cddbf6d..b8bc360 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1648,6 +1648,10 @@ static void vmxnet3_handle_command(VMXNET3State *s, uint64_t cmd) VMW_CBPRN("Set: Get upper part of device ID"); break; + case VMXNET3_CMD_GET_DEV_EXTRA_INFO: + VMW_CBPRN("Set: Get device extra info"); + break; + default: VMW_CBPRN("Received unknown command: %" PRIx64, cmd); break; @@ -1667,6 +1671,7 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State *s) case VMXNET3_CMD_RESET_DEV: case VMXNET3_CMD_QUIESCE_DEV: case VMXNET3_CMD_GET_QUEUE_STATUS: + case VMXNET3_CMD_GET_DEV_EXTRA_INFO: ret = 0; break; -- 1.9.1