From: Miao Yan <yanmiaobest@gmail.com>
To: jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org
Cc: Miao Yan <yanmiaoebest@gmail.com>
Subject: [Qemu-devel] [PATCH v3 5/5] net/vmxnet3: rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION
Date: Tue, 22 Dec 2015 22:06:11 -0800 [thread overview]
Message-ID: <1450850771-42884-6-git-send-email-yanmiaobest@gmail.com> (raw)
In-Reply-To: <1450850771-42884-1-git-send-email-yanmiaobest@gmail.com>
VMXNET3_DEVICE_VERSION is used as return value for accessing
UPT Revision Report and Selection register. So rename it
to VMXNET3_UPT_REVISION.
Signed-off-by: Miao Yan <yanmiaoebest@gmail.com>
---
hw/net/vmxnet3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index a429405..fba1d73 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -50,7 +50,7 @@
#define VMXNET3_LINK_STATUS_UP 0x1
/* Least significant bit should be set for revision and version */
-#define VMXNET3_DEVICE_VERSION 0x1
+#define VMXNET3_UPT_REVISION 0x1
#define VMXNET3_DEVICE_REVISION 0x1
/* Number of interrupt vectors for non-MSIx modes */
@@ -1837,7 +1837,7 @@ vmxnet3_io_bar1_read(void *opaque, hwaddr addr, unsigned size)
/* UPT Version Report Selection */
case VMXNET3_REG_UVRS:
VMW_CBPRN("Read BAR1 [VMXNET3_REG_UVRS], size %d", size);
- ret = VMXNET3_DEVICE_VERSION;
+ ret = VMXNET3_UPT_REVISION;
break;
/* Command */
--
1.9.1
next prev parent reply other threads:[~2015-12-23 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 6:06 [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3 Miao Yan
2015-12-23 6:06 ` [Qemu-devel] [PATCH v3 1/5] net/vmxnet3: return 1 on device activation failure Miao Yan
2015-12-23 6:06 ` [Qemu-devel] [PATCH v3 2/5] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command Miao Yan
2015-12-23 6:06 ` [Qemu-devel] [PATCH v3 3/5] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO Miao Yan
2015-12-23 6:06 ` [Qemu-devel] [PATCH v3 4/5] net/vmxnet3: return 0 on unknown command Miao Yan
2015-12-23 6:06 ` Miao Yan [this message]
2015-12-23 6:29 ` [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3 Dmitry Fleytman
2015-12-24 2:53 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450850771-42884-6-git-send-email-yanmiaobest@gmail.com \
--to=yanmiaobest@gmail.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanmiaoebest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).