From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBfRF-0006M1-Tt for qemu-devel@nongnu.org; Wed, 23 Dec 2015 04:10:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBfRA-0005OZ-SC for qemu-devel@nongnu.org; Wed, 23 Dec 2015 04:10:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBfRA-0005Nn-NS for qemu-devel@nongnu.org; Wed, 23 Dec 2015 04:10:24 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 73C4F8F4F2 for ; Wed, 23 Dec 2015 09:10:24 +0000 (UTC) From: Bandan Das Date: Wed, 23 Dec 2015 14:39:46 +0530 Message-Id: <1450861787-16213-2-git-send-email-bsd@redhat.com> In-Reply-To: <1450861787-16213-1-git-send-email-bsd@redhat.com> References: <1450861787-16213-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] usb-mtp: use safe variant when cleaning events list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Bandan Das , kraxel@redhat.com usb_mtp_inotify_cleanup uses QLIST_FOREACH to pick events from a list and free them which is incorrect. Use QLIST_FOREACH_SAFE instead. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index af056c7..db1fd59 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -556,7 +556,7 @@ static int usb_mtp_inotify_init(MTPState *s) static void usb_mtp_inotify_cleanup(MTPState *s) { - MTPMonEntry *e; + MTPMonEntry *e, *p; if (!s->inotifyfd) { return; @@ -565,7 +565,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s) qemu_set_fd_handler(s->inotifyfd, NULL, NULL, s); close(s->inotifyfd); - QTAILQ_FOREACH(e, &s->events, next) { + QTAILQ_FOREACH_SAFE(e, &s->events, next, p) { QTAILQ_REMOVE(&s->events, e, next); g_free(e); } -- 2.6.2