From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBh7S-00082K-Hk for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:58:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBh7Q-0002S5-3K for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:58:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBh7P-0002Rv-U6 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:58:08 -0500 From: "Daniel P. Berrange" Date: Wed, 23 Dec 2015 10:57:55 +0000 Message-Id: <1450868277-25630-2-git-send-email-berrange@redhat.com> In-Reply-To: <1450868277-25630-1-git-send-email-berrange@redhat.com> References: <1450868277-25630-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 1/3] io: bind to loopback IP addrs in test suite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell The test suite currently binds to 0.0.0.0 or ::, which covers all interfaces of the machine. It is bad practice for test suite to open publically accessible ports on a machine, so switch to use loopback addrs 127.0.0.1 or ::1. Reported-by: Peter Maydell Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- tests/test-io-channel-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c index 194d043..e76d54c 100644 --- a/tests/test-io-channel-socket.c +++ b/tests/test-io-channel-socket.c @@ -261,7 +261,7 @@ static void test_io_channel_ipv4(bool async) listen_addr->type = SOCKET_ADDRESS_KIND_INET; listen_addr->u.inet = g_new0(InetSocketAddress, 1); - listen_addr->u.inet->host = g_strdup("0.0.0.0"); + listen_addr->u.inet->host = g_strdup("127.0.0.1"); listen_addr->u.inet->port = NULL; /* Auto-select */ connect_addr->type = SOCKET_ADDRESS_KIND_INET; @@ -295,7 +295,7 @@ static void test_io_channel_ipv6(bool async) listen_addr->type = SOCKET_ADDRESS_KIND_INET; listen_addr->u.inet = g_new0(InetSocketAddress, 1); - listen_addr->u.inet->host = g_strdup("::"); + listen_addr->u.inet->host = g_strdup("::1"); listen_addr->u.inet->port = NULL; /* Auto-select */ connect_addr->type = SOCKET_ADDRESS_KIND_INET; -- 2.5.0