From: chengang@emindsoft.com.cn
To: riku.voipio@iki.fi, laurent@vivier.eu
Cc: peter.maydell@linaro.org, Chen Gang <gang.chen.5i5j@gmail.com>,
Chen Gang <chengang@emindsoft.com.cn>,
qemu-devel@nongnu.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap
Date: Thu, 24 Dec 2015 09:07:33 +0800 [thread overview]
Message-ID: <1450919253-3237-1-git-send-email-chengang@emindsoft.com.cn> (raw)
From: Chen Gang <chengang@emindsoft.com.cn>
In this case, real_end is larger than end, which may cause mmap_frag
process the incorrect memory region.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
linux-user/mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 7b459d5..57b0361 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -536,7 +536,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
/* handle the end of the mapping */
if (end < real_end) {
ret = mmap_frag(real_end - qemu_host_page_size,
- real_end - qemu_host_page_size, real_end,
+ real_end - qemu_host_page_size, end,
prot, flags, fd,
offset + real_end - qemu_host_page_size - start);
if (ret == -1)
--
1.9.1
next reply other threads:[~2015-12-24 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 1:07 chengang [this message]
2015-12-24 1:21 ` [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap Chen Gang
2015-12-24 9:54 ` Laurent Vivier
2015-12-24 15:25 ` Chen Gang
2016-01-11 13:03 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450919253-3237-1-git-send-email-chengang@emindsoft.com.cn \
--to=chengang@emindsoft.com.cn \
--cc=gang.chen.5i5j@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).