qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: stefano.stabellini@eu.citrix.com
Subject: [Qemu-devel] [PATCH v2 0/4] Convert to realize()
Date: Sun, 27 Dec 2015 21:40:36 +0800	[thread overview]
Message-ID: <1451223640-2569-1-git-send-email-caoj.fnst@cn.fujitsu.com> (raw)

v2 changelog:
1. separate every supporting function into a single patch
2. Change supporting function type to void, for consistency
3. other fixes as per Stefano`s review

@Stefano: the last patch build failure you feedback:

qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’:
qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used uninitialized in this func

I admit it is careless misktake(fixed), but weird thing is, I confirmed
again, it indeed can compile in my environment, the evidence is:
1. every time I make after touching xen_pt_config_init.c, I can see the log:
    CC    x86_64-softmmu/hw/xen/xen_pt_config_init.o
    LINK  x86_64-softmmu/qemu-system-x86_64
2. $ readelf -s qemu-system-x86_64 | grep xen_pt_config_init , can got the
   symbol

Will the different compiler make the difference?(I am using
gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6))

Cao jin (4):
  Add Error **errp for xen_host_pci_device_get()
  Add Error **errp for xen_pt_setup_vga()
  Add Error **errp for xen_pt_config_init()
  Xen PCI passthru: convert to realize()

 hw/xen/xen-host-pci-device.c | 102 ++++++++++++++++++++++++-------------------
 hw/xen/xen-host-pci-device.h |   5 ++-
 hw/xen/xen_pt.c              |  73 +++++++++++++++++--------------
 hw/xen/xen_pt.h              |   5 ++-
 hw/xen/xen_pt_config_init.c  |  48 ++++++++++----------
 hw/xen/xen_pt_graphics.c     |  11 ++---
 6 files changed, 134 insertions(+), 110 deletions(-)

-- 
2.1.0

             reply	other threads:[~2015-12-27 13:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-27 13:40 Cao jin [this message]
2015-12-27 13:40 ` [Qemu-devel] [PATCH v2 1/4] Add Error **errp for xen_host_pci_device_get() Cao jin
2016-01-04 15:15   ` Stefano Stabellini
2016-01-05  5:31     ` Cao jin
2016-01-05  7:23     ` Cao jin
2016-01-05 10:40       ` Stefano Stabellini
2016-01-05 12:41         ` Cao jin
2015-12-27 13:40 ` [Qemu-devel] [PATCH v2 2/4] Add Error **errp for xen_pt_setup_vga() Cao jin
2016-01-04 15:18   ` Stefano Stabellini
2015-12-27 13:40 ` [Qemu-devel] [PATCH v2 3/4] Add Error **errp for xen_pt_config_init() Cao jin
2016-01-04 15:23   ` Stefano Stabellini
2015-12-27 13:40 ` [Qemu-devel] [PATCH v2 4/4] Xen PCI passthru: convert to realize() Cao jin
2016-01-04 15:29   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451223640-2569-1-git-send-email-caoj.fnst@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).