qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
Cc: Dmitry Mishin <dim@virtuozzo.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Denis V. Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'
Date: Sun,  3 Jan 2016 18:07:46 +0300	[thread overview]
Message-ID: <1451833666-10564-1-git-send-email-den@openvz.org> (raw)

    commit 31e38a22a0c5a25646f966f001e1f5513d5a186d
    Author: Olga Krishtal <okrishtal@virtuozzo.com>
    Date:   Fri Dec 4 09:42:04 2015 +0300

        qemu-char: append opt to stop truncation of serial file

has added the option to the runtime but does not added it to -help
output.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
CC: Dmitry Mishin <dim@virtuozzo.com>
CC: Eric Blake <eblake@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
---
Changes from v2:
- removed comment about libvirt in the description
- rephrased the description by the suggestions from Eric

Changes from v1:
- fixed default value to 'off'

    qemu-options.hx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 215d00d..3544788 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2099,7 +2099,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
     "-chardev vc,id=id[[,width=width][,height=height]][[,cols=cols][,rows=rows]]\n"
     "         [,mux=on|off]\n"
     "-chardev ringbuf,id=id[,size=size]\n"
-    "-chardev file,id=id,path=path[,mux=on|off]\n"
+    "-chardev file,id=id,path=path[,mux=on|off][,append=on|off]\n"
     "-chardev pipe,id=id,path=path[,mux=on|off]\n"
 #ifdef _WIN32
     "-chardev console,id=id[,mux=on|off]\n"
@@ -2254,7 +2254,7 @@ console with the given dimensions.
 Create a ring buffer with fixed size @option{size}.
 @var{size} must be a power of two, and defaults to @code{64K}).
 
-@item -chardev file ,id=@var{id} ,path=@var{path}
+@item -chardev file ,id=@var{id} ,path=@var{path} [,append=@var{on|off}]
 
 Log all traffic received from the guest to a file.
 
@@ -2262,6 +2262,9 @@ Log all traffic received from the guest to a file.
 created if it does not already exist, and overwritten if it does. @option{path}
 is required.
 
+@option{append} specifies that QEMU should append to the file. The file is
+truncated if the option is omitted or is specified as off.
+
 @item -chardev pipe ,id=@var{id} ,path=@var{path}
 
 Create a two-way connection to the guest. The behaviour differs slightly between
-- 
2.1.4

             reply	other threads:[~2016-01-03 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-03 15:07 Denis V. Lunev [this message]
2016-01-04 15:45 ` [Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append' Eric Blake
2016-01-07 15:44   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451833666-10564-1-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=armbru@redhat.com \
    --cc=dim@virtuozzo.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).