From: "Denis V. Lunev" <den@openvz.org>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
"Denis V. Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now
Date: Thu, 7 Jan 2016 16:55:25 +0300 [thread overview]
Message-ID: <1452174932-28657-5-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1452174932-28657-1-git-send-email-den@openvz.org>
original idea to split calling locations was to spawn tracing thread
in the final child process according to
commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad
Author: Michael Mueller
Date: Mon Sep 23 16:36:54 2013 +0200
os_daemonize is now on top of both locations. Drop unneeded ifs.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/vl.c b/vl.c
index 210db41..1cd30b2 100644
--- a/vl.c
+++ b/vl.c
@@ -4116,10 +4116,8 @@ int main(int argc, char **argv, char **envp)
qemu_set_log(mask);
}
- if (!is_daemonized()) {
- if (!trace_init_backends()) {
- exit(1);
- }
+ if (!trace_init_backends()) {
+ exit(1);
}
/* If no data_dir is specified then try to find it relative to the
@@ -4680,12 +4678,6 @@ int main(int argc, char **argv, char **envp)
os_setup_post();
- if (is_daemonized()) {
- if (!trace_init_backends()) {
- exit(1);
- }
- }
-
main_loop();
replay_disable_events();
--
2.5.0
next prev parent reply other threads:[~2016-01-07 13:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:55 [Qemu-devel] [PATCH v4 00/11] simplify usage of tracepoints, and connect them to logging Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 01/11] trace: fix documentation Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 02/11] trace: split trace_init_events out of trace_init_backends Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 03/11] trace: split trace_init_file " Denis V. Lunev
2016-01-07 13:55 ` Denis V. Lunev [this message]
2016-01-07 13:55 ` [Qemu-devel] [PATCH 05/11] trace: add "-trace enable=..." Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 06/11] trace: add "-trace help" Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 07/11] log: do not unnecessarily include qom/cpu.h Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 09/11] trace: convert stderr backend to log Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 10/11] trace: switch default backend to "log" Denis V. Lunev
2016-01-07 13:55 ` [Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN" Denis V. Lunev
2016-01-07 17:04 ` [Qemu-devel] [PATCH v4 00/11] simplify usage of tracepoints, and connect them to logging Eric Blake
2016-01-07 20:42 ` Denis V. Lunev
2016-01-14 7:25 ` Denis V. Lunev
2016-01-15 18:27 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2015-10-29 20:44 [Qemu-devel] [PATCH v3 " Denis V. Lunev
2015-10-29 20:44 ` [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now Denis V. Lunev
2015-10-26 9:10 [Qemu-devel] [PATCH v2 00/11] simplify usage of tracepoints, and connect them to logging Denis V. Lunev
2015-10-26 9:10 ` [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now Denis V. Lunev
2015-10-26 17:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452174932-28657-5-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).