From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHGmP-0007BP-O2 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 15:03:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHGmO-00009A-Op for qemu-devel@nongnu.org; Thu, 07 Jan 2016 15:03:29 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:40438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHGmO-00008E-9J for qemu-devel@nongnu.org; Thu, 07 Jan 2016 15:03:28 -0500 From: Wei Liu Date: Thu, 7 Jan 2016 19:56:08 +0000 Message-ID: <1452196584-17259-12-git-send-email-wei.liu2@citrix.com> In-Reply-To: <1452196584-17259-1-git-send-email-wei.liu2@citrix.com> References: <1452196584-17259-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2 11/27] fsdev: 9p-marshal: introduce V9fsBlob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Wei Liu , "Aneesh Kumar K.V" , Greg Kurz Introduce a concept of blob. It will be used to pack / unpack xattr value. With this change there is no need to expose v9fs_pack to device code anymore. Signed-off-by: Wei Liu --- fsdev/9p-marshal.c | 7 +++++++ fsdev/9p-marshal.h | 14 ++++++++++++++ fsdev/virtio-9p-marshal.c | 26 ++++++++++++++++++++++++++ 3 files changed, 47 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index 991e35d..a914244 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -54,3 +54,10 @@ void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs) v9fs_string_free(lhs); v9fs_string_sprintf(lhs, "%s", rhs->data); } + +void v9fs_blob_free(V9fsBlob *blob) +{ + g_free(blob->data); + blob->data = NULL; + blob->size = 0; +} diff --git a/fsdev/9p-marshal.h b/fsdev/9p-marshal.h index e91b24e..5a0150b 100644 --- a/fsdev/9p-marshal.h +++ b/fsdev/9p-marshal.h @@ -7,6 +7,12 @@ typedef struct V9fsString char *data; } V9fsString; +typedef struct V9fsBlob +{ + uint16_t size; + void *data; +} V9fsBlob; + typedef struct V9fsQID { int8_t type; @@ -81,4 +87,12 @@ extern void v9fs_string_null(V9fsString *str); extern void v9fs_string_sprintf(V9fsString *str, const char *fmt, ...); extern void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs); +static inline void v9fs_blob_init(V9fsBlob *blob) +{ + blob->data = NULL; + blob->size = 0; +} + +extern void v9fs_blob_free(V9fsBlob *blob); + #endif diff --git a/fsdev/virtio-9p-marshal.c b/fsdev/virtio-9p-marshal.c index f236bab..c3ac316 100644 --- a/fsdev/virtio-9p-marshal.c +++ b/fsdev/virtio-9p-marshal.c @@ -142,6 +142,21 @@ ssize_t v9fs_unmarshal(struct iovec *out_sg, int out_num, size_t offset, } break; } + case 'B': { + V9fsBlob *blob = va_arg(ap, V9fsBlob *); + copied = v9fs_unmarshal(out_sg, out_num, offset, bswap, + "w", &blob->size); + if (copied > 0) { + offset += copied; + blob->data = g_malloc(blob->size); + copied = v9fs_unpack(blob->data, out_sg, out_num, offset, + blob->size); + if (copied < 0) { + v9fs_blob_free(blob); + } + } + break; + } case 'Q': { V9fsQID *qidp = va_arg(ap, V9fsQID *); copied = v9fs_unmarshal(out_sg, out_num, offset, bswap, "bdq", @@ -241,6 +256,17 @@ ssize_t v9fs_marshal(struct iovec *in_sg, int in_num, size_t offset, } break; } + case 'B': { + V9fsBlob *blob = va_arg(ap, V9fsBlob *); + copied = v9fs_marshal(in_sg, in_num, offset, bswap, + "w", blob->size); + if (copied > 0) { + offset += copied; + copied = v9fs_pack(in_sg, in_num, offset, blob->data, + blob->size); + } + break; + } case 'Q': { V9fsQID *qidp = va_arg(ap, V9fsQID *); copied = v9fs_marshal(in_sg, in_num, offset, bswap, "bdq", -- 2.1.4