qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 2/7] ohci: fix Host Controller USBRESET
Date: Fri,  8 Jan 2016 11:40:10 +0100	[thread overview]
Message-ID: <1452249615-8222-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1452249615-8222-1-git-send-email-kraxel@redhat.com>

From: Hervé Poussineau <hpoussin@reactos.org>

Specification says that, when entering this state, "the contents of the registers
(except Root Hub registers) are preserved by the HC. [...] The Root Hub is being reset,
which causes the Root Hub's downstream ports to be reset and possibly powered off."

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-id: 1450567431-31795-3-git-send-email-hpoussin@reactos.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/hcd-ohci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 0661804..24c62b4 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1451,7 +1451,7 @@ static void ohci_set_ctl(OHCIState *ohci, uint32_t val)
         trace_usb_ohci_resume(ohci->name);
         break;
     case OHCI_USB_RESET:
-        ohci_hard_reset(ohci);
+        ohci_roothub_reset(ohci);
         break;
     }
 }
-- 
1.8.3.1

  parent reply	other threads:[~2016-01-08 10:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 10:40 [Qemu-devel] [PULL 0/7] usb patch queue Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 1/7] ohci: split reset method in 3 parts Gerd Hoffmann
2016-01-08 10:40 ` Gerd Hoffmann [this message]
2016-01-08 10:40 ` [Qemu-devel] [PULL 3/7] ohci: fix command HostControllerReset Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 4/7] usb-mtp: use safe variant when cleaning events list Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 5/7] usb-mtp: fix call to trace function Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 6/7] ohci: delay first SOF interrupt Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 7/7] ohci: clear pending SOF on suspend Gerd Hoffmann
2016-01-08 12:50 ` [Qemu-devel] [PULL 0/7] usb patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452249615-8222-3-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).